#446 Repos refresh doesn't update favorite's paths

[Misanthropist.Just.Visiting]

The repos refresh only updates the paths in the repository.xml but not in the favorites.xml. Thus after external rearrange I cannot play any favorites anymore and have to re-add them again. (In my case >2k files )

[Misanthropist.Just.Visiting]

xmls just for reference

[fleax]

I try this issue hard to fix, given how the refresh process is done: refresh don't detect if a file has been moved, and if it would do, how to detect its new location?

[Misanthropist.Just.Visiting]

I imagine the pseudo-code for an update function could be:

//contains compares only tags, not file location
if found = repository.containsWithSameTags(audiofile)
if found exists on harddrive
found.setPath(audiofile.gethPath)
else
repository.add(audiofile)

[Misanthropist.Just.Visiting]

oh darn my last comment lost formatting
//contains compares only tags, not file location
if (found = repository.containsWithSameTags(audiofile) ){
if (found exists on harddrive) found.setPath(audiofile.gethPath)}
}else repository.add(audiofile)

[fleax]

That means that two files are equals if have the same tags, which is not the current behaviour of favorites, so I think we must change that before, so when setting a song as favorite, all songs with same tag will be favorite too.

That is in fact the behaviour of option "import favorites from last.fm", where all songs with same tag are marked as favorite.