Re: [Asunit-users] Verbose assertEquals

[Luke B. <lb...@gm...>]

Thanks so much for putting in this work Darren.

I do agree that the proposed change is an improvement over what we have
today and I am happy to integrate the patch for my own projects.

I am, however, concerned about breaking other people's existing tests.
Personally, to your point, I don't think this would break any of my tests
and if it did, it would be trivial to fix. Unfortunately, I'm hesitant to
release this as it may have a negative effect on other people's time.

In light of these concerns, I'd like to put it to a vote for our users.

If you're interested in this topic, please respond to the list with your
vote:

a) You would like to see assertSame and assertEquals cleaned up according t=
o
the previous discussion
b) You would like to see assertSame and assertEquals left as is

I vote for (a), but would defer to the community if they feel strongly abou=
t
it.
Since Darren did the work already, I'm going to assume that he's in the a)
camp too.

Votes:
a) 2
b) 0


Anyone want to weigh in on this?


Thanks,


Luke Bayes
www.asunit.org


I've gone ahead and done this, for all types of objects. See the
> Assert.as file in the zip file attached to the other email I just sent.
>
> Warning: it is backwards-incompatible if you've used assertEquals to
> compare objects/arrays when you really intended to do what assertSame
> does. Apologies if "fix your code" sounds too harsh :-).
>
> Darren
>