Re: [Asunit-users] asunit from commandline

[Luke B. <lb...@gm...>]

Hey Darren,

Thanks for checking into this. Answers inline below:

http://svn.sourceforge.net/viewcvs.cgi/asunit/trunk/framework/as2/com/asuni=
t/framework/TestRunner.as?view=3Dmarkup&rev=3D2
>
> I think the renderTests(arr:Array) function should be changed to
> renderTests(Void), and then change:
>                 lc["addTests"](arr);
>                 tests =3D new Array();
> to read:
>                 lc["addTests"](tests);
>                 tests =3D new Array();
>
> The reason is simply that this.tests gets reset so passing in anything
> other than this.tests is dangerous.


Good point. Thanks!


While there I think renderTests() and getLocalConn() can be changed from
> public to private: no other classes seem to call them.


This seems correct to me too.


addSuccess() and addFailure() don't seem to be called from anywhere at
> all. What are they for, and do they need to be part of the public
> interface?


I believe these methods can actually be removed. They represented an early
design that didn't make it into the final build.

Overall - nice finds!

I'll update the source in svn right now with these changes.


Luke Bayes
www.asunit.org