Menu

#563 Indented function arguments are wrong if function is a class member

closed-fixed
None
2024-09-08
2024-02-27
No

Looks like #434 introduced a regression.

Example:

obj.doThing(
1,
2,
"3"
);

Expected:

obj.doThing(
    1,
    2,
    "3"
);

Actual:

obj.doThing(
        1,
        2,
        "3"
    );

Tested with all sorts of command line options, but it works with the default call of just astyle file.cpp.
Tested with 3.4.12.

Discussion

  • André Simon

    André Simon - 2024-03-06
    • status: open --> open-accepted
    • assigned_to: André Simon
     
  • André Simon

    André Simon - 2024-03-06

    It looks similar to 434 but indeed it is a very old behavior.

     
  • André Silva

    André Silva - 2024-08-19

    I'd like to bring attention to this issue again since it's a fairly bad bug. And because it looks like the problem got introduced with change #434, it's probably best to examine it and maybe revert #434 soon, before the codebase gets more complex and it becomes too hard to revert.

     
  • André Silva

    André Silva - 2024-08-20

    That seems to have solved it just fine. Thank you!

     
  • André Simon

    André Simon - 2024-09-08
    • status: open-accepted --> closed-fixed
     
  • André Simon

    André Simon - 2024-09-08

    Released in 3.6.1

     

Log in to post a comment.

MongoDB Logo MongoDB