Re: [Assimp-discussions] PyAssimp improvements

[Guillaume B. <gui...@gm...>]

Hmmmm… I did, and you merged it :D

PR #1226 <https://github.com/assimp/assimp/pull/1226>.

Thanks again :-)

Guillaume


Le 03/05/2017 à 20:30, kim kulling a écrit :
> Hi,
>
> you can generate a pull-request for that. Just check the github-page 
> how to do so. There are already some great tutorials out there!
>
> Kim
>
> Guillaume Bittoun <gui...@gm... 
> <mailto:gui...@gm...>> schrieb am Fr., 7. Apr. 2017 um 
> 21:30 Uhr:
>
>     Hi everyone,
>
>     I am currently using the assimp wrapping for python and I was
>     wondering
>     if I could add two tiny improvements to it:
>
>     1) I tried to use the 3d_viewer.py and the bad surprise for me was
>     that
>     the shader (surprisingly) couldn’t compile on my mac because the
>     required shader version is v1.30. I had to adapt the shaders for
>     version
>     1.20 and then it worked. Therefore, I was wondering if I could either
>     change the shaders of 3d_viewer.py to v1.20 or add a way to compile
>     shader v1.20 if the v1.30 didn’t succeed ?
>
>     2) Concerning the pyassimp installation, I was glad to see that there
>     was a setup.py file, which is great ! But unfortunately, this setup
>     doesn’t install the libassimp.dylib (or .so/.dll) binary and as I
>     didn’t
>     install assimp on my computer (ie. I didn’t run “make install”), I
>     couldn’t import the pyassimp package. Of course, most of the time,
>     people install assimp libraries before using the python wrapping
>     but on
>     my team we are (unfortunately) using different versions of assimp
>     in our
>     projects and we don’t want to mix them in the /usr/local/lib
>     directory.
>     When installing the pyassimp package, I think it could be better to
>     install both the python api + the library inside the site-package.
>     This
>     way it could also be installed in a virtual environment and be
>     isolated
>     from other versions of pyassimp if you want to.
>
>     I am currently trying to implement these improvements but if you think
>     my request is not relevant or that I missed a way for compiling the
>     shaders in 3d_viewer or a way to install libassimp in a virtual
>     environment, feel free to warn me.
>
>     Moreover, I was wondering if there was a documentation on “how to
>     contribute”, does anyone know if there is one ?
>
>     Best regards,
>     Guillaume
>
>     ------------------------------------------------------------------------------
>     Check out the vibrant tech community on one of the world's most
>     engaging tech sites, Slashdot.org! http://sdm.link/slashdot
>     _______________________________________________
>     Assimp-discussions mailing list
>     Ass...@li...
>     <mailto:Ass...@li...>
>     https://lists.sourceforge.net/lists/listinfo/assimp-discussions
>