#36 false Animation data

[Anonymous]

when Importing from collada, there are some false data in aiAnimation (I'm using openCollada in 3dsmax)
- aiAnimation::mTicksPerSecond is 1.0, which should be 0.0 (as long as it is not specified in collada file) according to documentation
- aiAnimation::mDuration is 1 frame less that is supposed to be, if you see the mTime last key, it is equal to mDuration.

- Sepul

[Alexander Gessler]

(Not the maintainer of the Collada loader).

I think the 2nd point is what most loaders do, duration is usually the highest time value found in all keys and not this time plus the length of a 'frame' (or rather the length of the last 'frame' in the keyframe list, not all frames need to be of the same length). If we change it here, we need to change it everywhere.

Thomas (in case you read this), any opinion?

Bye, Alex

[Thomas Ziegenhagen]

First point: this might be a bug. I'll check.
Second point: this is not a bug, it's correct behaviour. A animation keyframe has no duration, it's a simple point in time with a given value. Therefore the duration of an animation is the time of the last key frame. Usually looped animations have the same values for the first and the last key frame, while other animations have last key frames that suit the set of possible follow-up animations.

[Kim Kulling]

see: https://github.com/assimp/assimp/issues/155