#390 M68K/BCPL: runCommand stack size should be larger

m68k-amiga
closed-fixed
Shell/DOS (109)
5
2013-02-18
2012-03-01
Mark K
No

I compared the AROS BCPL runCommand routine with the Kickstart 1.3 equivalent at address $FF48E6.

The D2 argument to runCommand (stack size in longwords) is used as an argument to getvec. So the actual allocation length is D2 + 1 longwords. You need to addq.l #1,d2 on entry to the routine in the AROS version.

runCommand is not void. It returns the value that the command returned in D0, in D1. (The current AROS code does do that; it just says void in the routine comment.)

Discussion

  • Jason S. McMullan

    Fixed in r44782 - please verify

     
  • Jason S. McMullan

    • status: open --> open-fixed
     
  • Krzysztof Smiechowicz

    • assigned_to: nobody --> ezrec
    • status: open-fixed --> closed-fixed
     

Log in to post a comment.