From: Jo S. <jo....@gm...> - 2006-05-17 21:34:00
|
The add ( ... List ...) functions are all used in the groovy scripts in data/script for the definition of NPCs. It's probably a philosophical question but I personally can read NPC.add better than Behaviour.addReply especially as we're adding something to the NPC and not to the Behaviours. Am 17.05.2006 um 19:16 schrieb Daniel Herding > Modified Files: > Behaviours.java SpeakerNPC.java > Log Message: > Use constants for SpeakerNPC state machine's states > > Marked unused methods as deprecated |
From: Daniel H. <DHe...@gm...> - 2006-05-17 21:52:20
|
Jo Seiler schrieb: > The add ( ... List ...) functions are all used in the groovy scripts in > data/script for the definition of NPCs. OK, I'll remove the deprecated markings next time I edit the files. > It's probably a philosophical question but I personally can read NPC.add > better than Behaviour.addReply especially as we're adding something to > the NPC and not to the Behaviours. I think that less parameters means better readability. But I agree with you that addReply() looks weird as a function of Behaviour. IMHO, it should be a method of SpeakerNPC. In fact, the Behaviour "class" is no OO class at all, it's just a toolbox of useful functions that should really be methods of SpeakerNPC. Look at the Javadoc: they're all static functions. We could move them all over to SpeakerNPC and scrap Behaviours.java, but then SpeakerNPC.java would become really large. Any ideas or opinions? Daniel |
From: Miguel A. B. L. <mig...@ho...> - 2006-05-17 22:26:03
|
>I think that less parameters means better readability. But I agree with >you that addReply() looks weird as a function of Behaviour. IMHO, it >should be a method of SpeakerNPC. In fact, the Behaviour "class" is no >OO class at all, it's just a toolbox of useful functions that should >really be methods of SpeakerNPC. Look at the Javadoc: they're all static >functions. > >We could move them all over to SpeakerNPC and scrap Behaviours.java, but >then SpeakerNPC.java would become really large. Any ideas or opinions? I wrote Behaviours to make SpeakerNPC simpler, just for that. Perhaps the different behaviours could be subclasses of SpeakerNPC. |