Menu
▾
▴
#308 Port forwarding support
It would be nice if aria2c could automatically configure UPnP port forwarding - I recommend just handing it off to something like tor-fw-helper ( https://gitweb.torproject.org/tor.git/blob/HEAD:/doc/tor-fw-helper.1.txt ) for that. TOR is under BSD 3-clause, so there shouldn't be problems using that code.
Where would an appropriate place to put any relevant code? SocketCore feels a bit too low-level (nothing in there seems appropriate to figuring out if we need forwarding / what to use), but I've only been scanning the code for a minute and could certainly be hilariously wrong.
I don't know much about upnp stuff, so don't know where is appropriate, but tor-fw-helper looks like a program to upnp.. so we don't need to integrate it into aria2 codebase?
I was thinking that aria2 can call tor-fw-helper at the appropriate point if it's available; indeed, it does not need to be integrated into the aria2 codebase (but the option is available if desired). I just wasn't smart enough to know where would be the right place to call it :)
aria2 code base is not small and even the aria2 developer cannot find the good place to insert new code immediately, so don't mind.
Personally I'd like to avoid calling external program from aria2 binary, but if it were integrated, it may be in BtSetup.cc and DHTSetup.cc.