Re: [PATCH] Win32 improvements (mouse, fullscreen...)

[Tarnyko <ta...@ta...>]

Hey, thanks for testing Ian ! 

> something other than kpd-+ would be good to get
> out of this (ctrl+alt is used for VMWare - we should make the combination
> easier to set up anyway)

I agree. Personally wanted to set Alt+M as alternative, but felt 
uncomfortable doing it for my first patch, as kpd-+ was already chosen... 

UNIX version allows setting this at runtime with the ARCEMXMOUSEKEY 
environment variable. Windows version should have a dialog box instead; plan 
to add, you can be sure it will end up full of options on the long run :). 

> Paste kinda works, but misses many characters.  Amusing implementation using a timer, and I'm not sure where the losses are happening

Good catch. I guess it depends on the host computer ; was able to reproduce 
it on a different machine.
The issue is that Arcem polls the keyboard by itself, the timing may vary, 
and you have to align on its timing. I chose a fixed timing (30ms) here, but 
eventually will have to bind with the lower-level code to be 100% accurate. 

PS : Other feature I'd like to add quickly : choosing a floppy disk image 
with a file browser ("Open...") dialog box. 

Regards, Tarnyko 

Ian Jeffray writes: 

> Fullscreen works fine (Hilarious on a 4K monitor).
> Capture mouse is good, but something other than kpd-+ would be good to get
> out of this (ctrl+alt is used for VMWare - we should make the combination
> easier to set up anyway)
> Paste kinda works, but misses many characters.  Amusing implementation using
> a timer, and I'm not sure where the losses are happening - I'm running on a
> 4GHz Skylake here so it can't be a performance issue surely. 
> 
> Not much time to play today - will look at the patch a bit more later in the
> week. 
> 
> Ian 
> 
> -----Original Message-----
> From: Tarnyko [mailto:ta...@ta...] 
> Sent: 13 December 2016 17:25
> To: Ian Jeffray <ia...@je...>
> Cc: arc...@li...
> Subject: Re: [PATCH] Win32 improvements (mouse, fullscreen...) 
> 
> Thanks Ian, this is really appreciated !  
> 
> I plan to fix more bugs and eventually implement sound, but before that,
> some feedback would be nice :).  
> 
> Tarnyko  
> 
> Ian Jeffray writes:  
> 
>> Nice work, I'll try it later!  
>> 
>> Ian 
>> 
>> On 13/12/2016 14:26, Tarnyko wrote:
>>> Hi ArcEm devs, 
>>>
>>> I just posted a patch improving the Windows frontend (most notably 
>>> improving the mouse, adding floppy insertion/ejection, fullscreen,
> paste...).
>>>
>>> This is here, with screenshots and a "demo" binary :  
>>>
>>> https://sourceforge.net/p/arcem/bugs/20/ 
>>>
>>> Anybody interested in taking a look at it ? Who should I bring the 
>>> matter to if needed, Peter Naulls ? 
>>>
>>> Regards,
>>> Tarnyko 
>>>
>>> ---------------------------------------------------------------------
>>> --------- Check out the vibrant tech community on one of the world's 
>>> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot 
>>>
>> 
>> ----------------------------------------------------------------------
>> -------- Check out the vibrant tech community on one of the world's 
>> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> --
>> arcem-devel mailing list
>> arc...@li...
>> https://lists.sourceforge.net/lists/listinfo/arcem-devel
> 
> ----------------------------------------------------------------------------
> --
> Check out the vibrant tech community on one of the world's most engaging
> tech sites, SlashDot.org! http://sdm.link/slashdot
> --
> arcem-devel mailing list
> arc...@li...
> https://lists.sourceforge.net/lists/listinfo/arcem-devel 
> 
>  
> 
> ------------------------------------------------------------------------------
> Check out the vibrant tech community on one of the world's most 
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> -- 
> arcem-devel mailing list
> arc...@li...
> https://lists.sourceforge.net/lists/listinfo/arcem-devel