Menu

#115 Add Codex support and testing

closed
nobody
None
2026-04-21
2026-04-13
Anonymous
No

Originally created by: kumaakh
Originally owned by: dsiddharth2

Concrete bug (reported in comment by kumaakh)

1. config.toml TOML quoting is broken

When apra-fleet installs Codex CLI, it writes `config.toml` with backslash-escaped values instead of proper TOML double-quoted strings.

Written (broken):
```toml
model = \gpt-5.3-codex
provider = \openai
```

Expected:
```toml
model = "gpt-5.3-codex"
provider = "openai"
```

Audit the `config.toml` generation/write logic to ensure values are emitted as `"value"` (TOML string literal), not `\value\`.

2. Silent provider fallback is dangerous

If the fleet server cannot parse a member's provider config (e.g. malformed TOML), it silently falls back to Claude without any notification. The PM skill ran the reviewer on Claude without the user knowing — only discovered when the user noticed unexpected behaviour.

When provider config parsing fails, surface a clear error and notify the PM rather than silently switching.

  • [#27] — OpenAI Codex multi-provider support (broader tracking issue)

Related

Tickets: #143
Tickets: #27

Discussion

  • Anonymous

    Anonymous - 2026-04-13
     
  • Anonymous

    Anonymous - 2026-04-13
     
  • Anonymous

    Anonymous - 2026-04-14

    Originally posted by: kumaakh

    Feedback: Codex install corrupts config.toml quoting

    When apra-fleet installed Codex CLI, it wrote config.toml with backslash-escaped values instead of proper TOML double-quoted strings:

    Written (broken):

    model = \gpt-5.3-codexprovider = \openai```
    
    **Expected:**
    :::toml
    

    model = "gpt-5.3-codex"
    provider = "openai"

    ### Impact
    
    The malformed TOML caused the fleet server to fail to read the provider/model for the Codex member. The PM skill silently fell back to Claude models for that member **without any notification** — meaning the reviewer was running on Claude without the user knowing. This was only discovered when the user asked the reviewer direct questions and noticed the behaviour change.
    
    ### Steps to reproduce
    
    
    1. Register a Codex member
    2. Have apra-fleet install Codex CLI on that member
    3. Inspect `~/.codex/config.toml` — values will be backslash-quoted instead of double-quoted
    
    ### Fix applied by user
    
    Manually corrected the quoting in `config.toml`. After the fix, Codex CLI worked correctly for reviews.
    
    ### Suggested fixes
    
    
    1. **Config write**: audit the `config.toml` generation/write logic to ensure values are emitted as `"value"` (TOML string literal), not `\value\`
    2. **Silent fallback is dangerous**: if the fleet server cannot parse a member's provider config, it should surface a clear error rather than silently switching to a default provider. The PM should be notified so it can escalate to the user.
    
     
  • Anonymous

    Anonymous - 2026-04-21

    Originally posted by: kumaakh

    Closed — fixed by PR [#143] (merged to main). Unknown provider now throws TypeError; Codex config.toml uses correctly quoted defaultModel string.

     

    Related

    Tickets: #143

  • Anonymous

    Anonymous - 2026-04-21

    Ticket changed by: kumaakh

    • status: open --> closed
     

Log in to post a comment.

MongoDB Logo MongoDB