[Aplaws-patches] [ aplaws-Patches-1783195 ] Notification Bugfix

[SourceForge.net <no...@so...>]

Patches item #1783195, was opened at 2007-08-28 11:11
Message generated for change (Comment added) made by cgyg9330
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=531527&aid=1783195&group_id=71505

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: chris gilbert (cgyg9330)
Assigned to: Nobody/Anonymous (nobody)
Summary: Notification Bugfix

Initial Comment:
In current trunk version, when a publish request is submitted, a notification phase is only applied if the user has entered an end date in the publish form.

This means if the applied lifecycle has an end date and a notification period is specified then there will be no notification unless the user overrides the end date of the lifecycle!!!

This code change fixes this, but there needs to be some data cleaning to sort out missed notifications. 

To limit the damage, you need to locate items that are still live and that do not have an expiry notification phase (there are ones where lifecycle hasn't finished and lifecycle has an end date but lifecycle does not have a phase with a phase definition labelled expirationImminent). I have a program (attached) that will identify and fix these, but because it is deployed in my custom application I cannot give you a version that will run straight away. Instead you need to take the java code and the pdl file and put them in one of your modules. There is no need to worry about where the pdl is placed - unlike a java class and its package, a pdl file doesn't have to sit in a location that reflects its model. The java class will need to have its package name changed to reflect the place you put it. Once you have put these somewhere and built them, execute ccm-run {your package}/CreateMissingNotificationPhases 

Identifying items that have already unpublished without a notification being sent is slightly more tricky - it may be easier to carry out a review of all unpublished items and check which ones are meant to be live.



----------------------------------------------------------------------

>Comment By: chris gilbert (cgyg9330)
Date: 2007-08-28 11:12

Message:
Logged In: YES 
user_id=1069385
Originator: YES

File Added: CreateMissingNotificationPhases.java

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=531527&aid=1783195&group_id=71505