Re: [Aperture-devel] Exif extraction skeleton for the flickr crawler

[Leo S. <leo...@df...>]

Ha, Antoni,
I sense overengineering here
 :-)

I would NOT suggest to make an abstraction layer if we have two 
implementations,
that are considerable different.

It takes longer to construct the proposed ExifUtil than to write it in 
FlickrCrawler,
actually it makes no difference to use ExifUtil, as it would always be 
many one-liners.

the mapping has mostly do be done by hand and by using a brain,
so I would propose to write it by hand in flickrcrawler,
and THEN maybe think about a framework,
otherwise we lose too much time here.

best
Leo

It was Antoni Mylka who said at the right time 10.08.2008 23:14 the 
following words:
> I've been browsing through your latest flickr crawler improvements. On
> the overall great job! It really starts like it's getting somewhere.
>
> One of the interesting things is the code you've introduced in revision 1389
>
> http://tinyurl.com/58cf4q
>
> We have a very similar problem with the exif-related code in the
> JpgExtractor. Both components would greatly benefit if the
> exif-handling code were externalized into a common util class. I would
> imagine some kind of ExifUtil with a single method
>
> public static void handleExifTag(String tagId, String tagValue,
> RDFContainer result) {}
>
> .. or whatever params are necessary. Then the flickr crawler would do:
>
> Collection<Exif> exifs = (Collection<Exif>)
> photosIf.getExif(photo.getId(), photo.getSecret());
> for (Exif exif : exifs) {
>     ExifUtil.handlerExifTab(exif.getTag(),exif.getRaw(),rdf);
> }
>
> As I said, I don't know which params are necessary, but having such a
> generic class, applicable in JpgExtractor and other Exif-related
> components that might appear in future would be very beneficial for
> Aperture as a whole.
>
> Keep up the good job.
>
>   


-- 
____________________________________________________
DI Leo Sauermann       http://www.dfki.de/~sauermann 

Deutsches Forschungszentrum fuer 
Kuenstliche Intelligenz DFKI GmbH
Trippstadter Strasse 122
P.O. Box 2080           Fon:   +49 631 20575-116
D-67663 Kaiserslautern  Fax:   +49 631 20575-102
Germany                 Mail:  leo...@df...

Geschaeftsfuehrung:
Prof.Dr.Dr.h.c.mult. Wolfgang Wahlster (Vorsitzender)
Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats:
Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
____________________________________________________