Re: [Aperture-devel] DataSource Detectors for the desktop - proposal for new DetectorFactory - done

[Leo S. <leo...@df...>]

It was Christiaan Fluit who said at the right time 04.07.2008 11:23 the 
following words:
> Leo Sauermann wrote:
>   
>> ok,
>>
>> I just committed the first version.
>> I still need to fiddle the build.xml to make it pack it correctly for OSGi,
>> and add the OSGi fiddlebits, but that should be ok by today.
>>
>> see
>> org.semanticdesktop.aperture.examples.detector.RunDetectors
>>
>> http://aperture.wiki.sourceforge.net/DataSourceDetectors
>>     
>
> Overall: looks good! Some remarks:
>
> - Why does the detect() method return a List? Perhaps a Set or 
> Collection is more appropriate?
>   
I like lists because you can get(0) and do more when iterating through them.
Especially, you can call collections.sort(detectedsource, mycomparator) 
on the result, which is something many users will do. Although a Set or 
a Collection may be "semantically super-correct", they don't help the 
programmer retrieving the list, whereas a List is very handy.

I often end up converting the sets/collections back to lists for 
sorting, and this sucks. As we used lists to build the list, there is no 
need to hide it when giving it back.

> - The HomeFolderDetector does not do what its name suggests, as 
> generally $HOME != $MYDOCUMENTS.
>   
ok, for windows this already worked. we read from the registry.
> - Quite a lot of Linux systems are nowadays using default directory 
> layouts with a Documents folder in the home dir, do we want to support 
> those as well? A simple heuristic could be: check whether 
> "$HOME/Documents" exists and else fall back to "$HOME".
>   

thx for the tip, I didn'T know they standardized it,
is changed now.

It was Herko ter Horst who said at the right time 04.07.2008 11:37 the 
following words:
> I'm not 100% sure which directory you want to get, but I believe a good, 
> cross-platform to obtain the "default" directory (as opposed to the 
> "home" directory) is to use 
> javax.swing.filechooser.FileSytemView.getDefaultDirectory(). This 
> returns "My Documents" on Windows.
for win, we have code reading the windows registry,
so thats ok.

> - Some copy-paste errors in DataSourceDetectorRegistryImpl: parameters 
> named "factory" that are better called "detector".
>   
thx! fixed

> - Inconsistent copyright and license headers: please make sure that all 
> files are "copyright 2008", that the API files use the joint Aduna & 
> DFKI copyright and use the AFL license, and all others copyright DFKI 
> and OSL license.
>   
whoops, I took what eclipse gave me and then copy/pasted the license 
from somewhere else.
I fixed now the Eclipse-configured Template to show the 2008 copyright 
when creating new
files.

best
Leo
>
> Regards,
>
> Chris
> --
>
> -------------------------------------------------------------------------
> Sponsored by: SourceForge.net Community Choice Awards: VOTE NOW!
> Studies have shown that voting for your favorite open source project,
> along with a healthy diet, reduces your potential for chronic lameness
> and boredom. Vote Now at http://www.sourceforge.net/community/cca08
> _______________________________________________
> Aperture-devel mailing list
> Ape...@li...
> https://lists.sourceforge.net/lists/listinfo/aperture-devel
>   


-- 
____________________________________________________
DI Leo Sauermann       http://www.dfki.de/~sauermann 

Deutsches Forschungszentrum fuer 
Kuenstliche Intelligenz DFKI GmbH
Trippstadter Strasse 122
P.O. Box 2080           Fon:   +49 631 20575-116
D-67663 Kaiserslautern  Fax:   +49 631 20575-102
Germany                 Mail:  leo...@df...

Geschaeftsfuehrung:
Prof.Dr.Dr.h.c.mult. Wolfgang Wahlster (Vorsitzender)
Dr. Walter Olthoff
Vorsitzender des Aufsichtsrats:
Prof. Dr. h.c. Hans A. Aukes
Amtsgericht Kaiserslautern, HRB 2313
____________________________________________________