You can subscribe to this list here.
2002 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(21) |
---|---|---|---|---|---|---|---|---|---|---|---|---|
2003 |
Jan
(136) |
Feb
(104) |
Mar
(80) |
Apr
(21) |
May
(36) |
Jun
(18) |
Jul
(22) |
Aug
(5) |
Sep
(11) |
Oct
(7) |
Nov
(3) |
Dec
(12) |
2004 |
Jan
(5) |
Feb
|
Mar
(3) |
Apr
(1) |
May
|
Jun
(1) |
Jul
(3) |
Aug
(6) |
Sep
(3) |
Oct
(4) |
Nov
(4) |
Dec
|
2005 |
Jan
(1) |
Feb
(4) |
Mar
|
Apr
(7) |
May
(4) |
Jun
(7) |
Jul
(4) |
Aug
(4) |
Sep
|
Oct
(8) |
Nov
(4) |
Dec
(1) |
2006 |
Jan
|
Feb
(3) |
Mar
(2) |
Apr
(4) |
May
|
Jun
(6) |
Jul
(2) |
Aug
(1) |
Sep
|
Oct
(3) |
Nov
|
Dec
|
2007 |
Jan
|
Feb
(4) |
Mar
(7) |
Apr
(4) |
May
(4) |
Jun
(8) |
Jul
(2) |
Aug
(2) |
Sep
|
Oct
|
Nov
(2) |
Dec
|
2009 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(2) |
Jun
(1) |
Jul
(3) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
2010 |
Jan
|
Feb
(1) |
Mar
|
Apr
(2) |
May
|
Jun
|
Jul
|
Aug
(1) |
Sep
|
Oct
|
Nov
|
Dec
|
From: Mitra <mi...@ea...> - 2003-03-11 22:33:56
|
Clearing up the points on these messages >3: StoreItem crashes when it calls the event code when running off >an anonymous form I've commented that call out in the CVS version >until someone (Jakub?) fixes the bug. >>> >>>Jakub: ad 3: I can not find the bug with StoreItem. Could you help >>>me? Everything is working fine for me. I have commented the rows >>>in again. Please could you try to comment out individual functions >>>in event_handler.php3 (like AuthUpdateReaders etc.) so that I know >>>which function caused troubles? Or could you give me some access >>>to some pages? > Mitra: I'll take more looks - won't be today - and see if I can track down the bug in StoreItem I'm not seeing any bugs in that Event code any more. >>I hope doc/script/show_result.php3 will help you with the results >>page. I don't know why you need to create an anonymous form >>otherwise than with a .shtml page. >> >> >>Because the anonymous form is on "site" i.e. created with >>modules/site, the only .shtml is a page containing<!--#include >>site.php3?....-->, so I take the PHP generated and put it into the >>site module, the URL on success is just '?i=10' meaning to go to >>item 10, which would be the thankyou page, and then "i=11" for >>failure, but I can't figure out what to put into the failure page. >> >> >>I can't put a SHTML include there, or PHP, all I can really put >>there is something inside {....} and have stringexpand.php3 expand >>it. I COULD put an {include} here if I could figure out what to >>put inside it, but it would make much more sense to do it directly >>with a {...} IF I COULD FIGURE OUT HOW THE RESULT IS STORED. >> >> >>>I think the SSI includes do most resemble the readfile() PHP >>>function. You only need to pass the post2sthml_id parameter to the >>>PHP scripts called by readfile(). This didn't work, what I ended up doing was 1: in site site config file (site/sites/site_bayfm.php3) define a function "myfillform" that called add_post2shtml to get the array, build an error message and return it 2: Insert that into $GLOBALS[eb_functions] so that it will be expanded when.... 3: Put {myfillform} into the site definition at the point I want the error message to appear. Note my example only shows validate errors, and it doesn't do the part about setting fields for editing records. I haven't figured out how to do that, and don't need it for what I'm doing. modules/site/sites/site_bayfm.php3 is checked into CVS as an example. >>When really complex stuff like this isbuilt, could you generate >>some ARCHITECTURE documentation, as well as the docs like >>anonym.html AND an example. Things that are obvious to the coder, >>just aren't obvious to someone else looking at it. For example in >>this case ..... we need to know. ...(this is just an example, I >>KNOW that I don't have it right, because I don't understand how >>this is working) >> >> >>1: insert_fnc_xxx generate errors like >>$GLOBALS[err][headline........] = "This string is too long" >> >>2: filler.php3 martials these and stores them in its own >>$err[validate] (NOTE THIS IS REUSE OF THE GLOBAL, THIS NEW >>$err HAS A DIFFERENT STRUCTURE FROM THE $err filled by >>insert_fnc_xxxx >> >>3: The result is stored somewhere ... >> >>4: The id parameter is passed back ... how? >> >>4: fillform.php3 gets this parameter from the URL which is the id >>field of the xxxx table >> >>and so on ..... >> >>>This documentation can be quite brief, but its crucial to being >>>able to debug. Without something like this, its impossible to >>>trace a bug back and know which step is doing it wrong, and there >>>is a real danger that one coder will go in and "FIX" something >>>which isn't a bug, and therefore break something else. This would still be useful - on each of the things you have done where there is tricky behavior (like storing intermediate results in arrays, serializing them and putting them in a database table! >>>1: The insert_fnc_fil etc functions don't always set $err[xxx] but >>>either return a value, or set $err (string) etc These bugs are still there in many places >>>2: Some validate functions return an error, even if there is not >>>one - for example if you try and post an anonymous form NOT >>>containing a publish date, to a slice where Publish_date is marked >>>as required&show then it will generate an error, rather than using >>>the default See separate thread - Honza reckons this SHOULD be an error -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-11 21:17:02
|
Any ideas on this? Jakub - is this something you changed, I think you were working in this code recently? - Mitra At 7:52 PM +1100 10/3/03, Mitra wrote: >Hi > >Something seems to have changed, > >If I go to >http://www.byronbayfm.org.au/apc-aa/admin/itemedit.php3?edit=1&encap=false&id=b8bfb5b72572cf14f9beb876d0d59046&change_id=c85a4a34ccbe0ce54c4306b5c32373b1&return_url=%2Fdraft.shtml%3Fi%3D26%26apc%3De1-26 > >Then I correctly get a login screen, but once I login I get > >http://www.byronbayfm.org.au/apc-aa/admin/index.php3?slice_id=c85a4a34ccbe0ce54c4306b5c32373b1&AA_CP_Session=8417cd6e26f9f5b67c88ba6636a81cd5&rXn=1 > >I.e. its dumped me into the Item Manager, when I was trying to get >to itemedit.php3. Its not a permission problem, I'm the superuser, > >This used to work just fine, Anyone know how this got broken, or >how to fix it? > >- Mitra > >-- >Mitra Technology Consulting - www.mitra.biz - mi...@mi... >02-6684-8096 or 0414-648-0722 > >Life is a Mystery to be Lived, not a Problem to be Solved -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Norbert B. <br...@ch...> - 2003-03-11 19:27:04
|
Jakub, when I set "use HTML" in Email Template for Alert, both body parts = (text/html and text/plain) of an email are base64 encoded. I guess this = might cause problms with some text only clients (and with email sent = through mailman). See example below. Should not be text/plain part just plain text and text/html part just = Mime Quoted Printable?=20 norbert br...@ch... Return-Path: <no...@cn...> Received: (from nobody@localhost) by cn10.changenet.sk (8.11.6/8.11.6) id h2BIH2303182; Tue, 11 Mar 2003 19:17:02 +0100 Date: Tue, 11 Mar 2003 19:17:02 +0100 Message-Id: <200...@cn...> To: br...@ch... Subject: CHANGENET.SK: Denny prehlad From: in...@ch... MIME-Version: 1.0 Content-Type: multipart/alternative; boundary=3D"-------AA-MULTI-Tp3aMJokf9PFi8xw2llZ------" Content-Transfer-Encoding: base64 Status: =20 ---------AA-MULTI-Tp3aMJokf9PFi8xw2llZ------ Content-Type: text/html; charset=3D"windows-1250" Content-Transfer-Encoding: base64 LyBESUdFU1Q8YnI+TY5QIFNSIHVyb2JpbG8gcHJ2/SBrcm9rIG5hIGNlc3RlIGs ... deleted ... 18gLyAgXyNNRV9OQU1FXyAvIF8jTUVfTUFJTF8gDQo=3D ---------AA-MULTI-Tp3aMJokf9PFi8xw2llZ------ Content-Type: text/plain; charset=3D"windows-1250" Content-Transfer-Encoding: base64 LyBESUdFU1QKTY5QIFNSIHVyb2JpbG8gcHJ2/SBrcm9rIG5hIGNlc3RlIGsgZG ... deleted ... V9fX18gLyAgXyNNRV9OQU1FXyAvIF8jTUVfTUFJTF8gDQo=3D ---------AA-MULTI-Tp3aMJokf9PFi8xw2llZ-------- |
From: Mitra <mi...@ea...> - 2003-03-11 10:11:19
|
At 9:32 AM +0100 11/3/03, Jakub Ad=E1mek wrote: >Mitra, > >neither 4.11 allows to redefine functions. I am not sure that ever >any PHP version allowed this. >Of course you must use only the aa_menus from the modules/site dir, >you don't want to see slice menus in a site module. Well we've only started seeing these problems as people moved to 4.3, or maybe as the require stuff was changed. I don't know why aa_menus was being defined twice, I just got the error message, I think it was on the week you were away. > The problem of util.php3 is not that of a developer but that of the >time which PHP needs to parse the file and which influences the >server answer time. Yes - I realize that, what I'm saying is that if util.php3 is TOO big , then split it into two and only include the part you need, DON't define the same functions twice. We have seen too many bugs that way. - Mitra > >-----Original Message----- >From: Mitra [mailto:mi...@ea...] >Sent: Saturday, March 08, 2003 11:35 PM >To: Jakub Adamek; apc...@so... >Subject: RE: [Apc-aa-coders] Redefining functions > >I have appended the original message about aa_menus, > >If util.php3 is getting too big, it would be MUCH easier to split it >up - util.php3 and utilcore.php3 and then require_once utilcore.php3 >from util.php3, this would be much better than redefining functions. > >Could you upgrade to PHP 4.3, this and later versions are where we >are seeing all the redefining problems. > >- Mitra > > >At 8:45 PM +0100 8/3/03, Jakub Adamek wrote: > >>Mitra, >> > > >you are very right. I didn't want to include the whole util.php3 >because of performance, but perhaps it is not as important. > > > >But about get_aamenus(): there is no reason why one script should >include several menu definitions. I didn't encounter this problem, >where was it? > > > >As to the PHP version: I am developing on 4.1.1. > > > >Jakub > > > >-----Original Message----- >From: apc...@li... >[mailto:apc...@li...] On Behalf Of Mitra >Sent: Friday, March 07, 2003 10:32 PM >To: apc...@so... >Subject: [Apc-aa-coders] Redefining functions > >Jakub - > > >I'm pulling this to a separate thread since its not really connected >to the filler problems > > >>the problem of defining new_id twice is fixed in CVS (if (! >>function_exists ("new_id"))). Can you perhaps do an update? I get >>always this error on refresh. >> > > >We are seeing a lot of problems with multiply defined functions, l >ately - I think they are becoming visible because the latest PHP >doesn't allow redefining functions. > > >It seems to me that we have a big weakness in apc-aa if we redefine >functions, take this example of new_id, the version in filler.php3 >is wrong, it misses a bug-fix that Honza made on the version in >util.php3. > > >It also makes it really hard to find bugs because it is not always >clear which version of a function is being used. > > >There was also an example reported to do with aa-menus (defined in >menu.php3 and modules/site/menu.php3) recently - a message on >1-march that was never dealt with. > > >Instead of redefining new_id, wouldn't it have been better to >include util.php3, I've deleted the code from post2shtml.php3 and >added require_once util.php3 I've done this and resubmitting to CVS. > > >Could someone (is site module Jakub or Honza?) fix aa_menus. > > >I'd also suggest upgrading your version of PHP so that you see these >problems on your dev machine. > > >- Mitra > > > >Here is the earlier message ..... > >>So what can we do - I'm not clear if Jakub is redeclaring the >>function for a reason? I tried a couple of things - like >>temporarily renaming the function in include/menu.php3 just while >>the site page loaded and that just broke things. >> > >At 11:31 AM +0100 28/2/03, Honza Malik wrote: > >>I tried it on our install. I moved our site module up and it works in >> >both configurations. > > >I think the problem could be in diffrerent versions of PHP. It seems, > >that new versions of PHP (>=3D4.3.0) do not allow redeclaration of > >functions (it was also the problem with gc() in PHPLib already reported > >in apc-aa-general). > > >On P=87, 2003-02-28 at 05:00, Mitra wrote: > > > The admin interface won't go to manage a site now, this seems to be > > > because get_aamenus is defined in both menu.php3 and > > > modules/site/menu.php3 > > > > > > its a strange bug, it works on one of my installations, but not the > > > other - they are both running the current CVS, only the data is > > > different. > > > > > > I think the main difference is that when you login to one you get a > > > slice, whereas on the other you get a site (alphabetical order) > > > > > > I'm not quite clear whether the name collision is deliberate, i.e. > > > redefining a function - or accidental > > > > > > Anyway, I think its a Jakub problem - and he's out this week I > > > understand? I can work around it on my machine, but this stops work > > > if anyone else has a "site" as their alphabetically first slice. > > >-- >Mitra Technology Consulting - www.mitra.biz - mi...@mi... >02-6684-8096 or 0414-648-0722 > >Life is a Mystery to be Lived, not a Problem to be Solved -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: <jak...@se...> - 2003-03-11 08:32:46
|
RE: [Apc-aa-coders] Redefining functionsMitra, neither 4.11 allows to redefine functions. I am not sure that ever any PH= P version allowed this. Of course you must use only the aa_menus from the modules/site dir, you don't want to see slice menus in a site module. The problem of util.php3 is not that of a developer but that of the time which PHP needs to parse the file and which influences the server answer time. Jakub -----Original Message----- From: Mitra [mailto:mi...@ea...] Sent: Saturday, March 08, 2003 11:35 PM To: Jakub Adamek; apc...@so... Subject: RE: [Apc-aa-coders] Redefining functions I have appended the original message about aa_menus, If util.php3 is getting too big, it would be MUCH easier to split it up= - util.php3 and utilcore.php3 and then require_once utilcore.php3 from util.php3, this would be much better than redefining functions. Could you upgrade to PHP 4.3, this and later versions are where we are seeing all the redefining problems. - Mitra At 8:45 PM +0100 8/3/03, Jakub Adamek wrote: Mitra, you are very right. I didn't want to include the whole util.php3 beca= use of performance, but perhaps it is not as important. But about get_aamenus(): there is no reason why one script should include several menu definitions. I didn't encounter this problem, where = was it? As to the PHP version: I am developing on 4.1.1. Jakub -----Original Message----- From: apc...@li... [mailto:apc...@li...] On Behalf Of Mitra Sent: Friday, March 07, 2003 10:32 PM To: apc...@so... Subject: [Apc-aa-coders] Redefining functions Jakub - I'm pulling this to a separate thread since its not really connecte= d to the filler problems the problem of defining new_id twice is fixed in CVS (if (! function_exists ("new_id"))). Can you perhaps do an update? I get always this error on refresh. We are seeing a lot of problems with multiply defined functions, l ately - I think they are becoming visible because the latest PHP doesn't allow redefining functions. It seems to me that we have a big weakness in apc-aa if we redefine functions, take this example of new_id, the version in filler.php3 is wro= ng, it misses a bug-fix that Honza made on the version in util.php3. It also makes it really hard to find bugs because it is not always clear which version of a function is being used. There was also an example reported to do with aa-menus (defined in menu.php3 and modules/site/menu.php3) recently - a message on 1-march tha= t was never dealt with. Instead of redefining new_id, wouldn't it have been better to inclu= de util.php3, I've deleted the code from post2shtml.php3 and added require_o= nce util.php3 I've done this and resubmitting to CVS. Could someone (is site module Jakub or Honza?) fix aa_menus. I'd also suggest upgrading your version of PHP so that you see thes= e problems on your dev machine. - Mitra Here is the earlier message ..... So what can we do - I'm not clear if Jakub is redeclaring the functio= n for a reason? I tried a couple of things - like temporarily renaming the function in include/menu.php3 just while the site page loaded and that ju= st broke things. At 11:31 AM +0100 28/2/03, Honza Malik wrote: I tried it on our install. I moved our site module up and it works = in both configurations. I think the problem could be in diffrerent versions of PHP. It seem= s, that new versions of PHP (>=3D4.3.0) do not allow redeclaration of functions (it was also the problem with gc() in PHPLib already reported in apc-aa-general). On P=E1, 2003-02-28 at 05:00, Mitra wrote: > The admin interface won't go to manage a site now, this seems to = be > because get_aamenus is defined in both menu.php3 and > modules/site/menu.php3 > > its a strange bug, it works on one of my installations, but not t= he > other - they are both running the current CVS, only the data is > different. > > I think the main difference is that when you login to one you get= a > slice, whereas on the other you get a site (alphabetical order) > > I'm not quite clear whether the name collision is deliberate, i.e. > redefining a function - or accidental > > Anyway, I think its a Jakub problem - and he's out this week I > understand? I can work around it on my machine, but this stops wo= rk > if anyone else has a "site" as their alphabetically first slice. -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-10 22:10:05
|
Ok - but how do we deal with the case where data is sometimes coming from the "Item Manager" interface, and sometimes from an anonymous form? What I want is for the anonymous form to set the default value. - Mitra At 7:17 PM +0100 10/3/03, Honza Malik wrote: >I think that if you set Required, then the data should be filled. If it >is not filled, it is error. If you do not want to generate error, you >can easily set it as "Not Required". > > Honza > >On Po, 2003-03-10 at 08:02, Mitra wrote: >> Hi >> >> I've got an error being generated from an anonymous form >> >> The anonymous form loads into a slice, where Publish_Date is marked >> as Required & Show, >> >> However, the anonymous form does NOT have Publish_Date on it, since I >> don't want anonymous users setting it. >> >> My thinking was that because Publish_Date has a Default set, it >> should set the default, but instead it generates an error. >> >> What do people think - should Required + Default mean to set the >> default, or generate an error? >> >> - Mitra >> >> -- >> Mitra Technology Consulting - www.mitra.biz - mi...@mi... >> 02-6684-8096 or 0414-648-0722 >> >> Life is a Mystery to be Lived, not a Problem to be Solved >> >> >> >> ------------------------------------------------------- >> This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger >> for complex code. Debugging C/C++ programs can leave you feeling lost and >> disoriented. TotalView can help you find your way. Available on major UNIX >> and Linux platforms. Try it free. www.etnus.com >> _______________________________________________ >> Apc-aa-coders mailing list >> Apc...@li... >> https://lists.sourceforge.net/lists/listinfo/apc-aa-coders >> > > > > >------------------------------------------------------- >This sf.net email is sponsored by:ThinkGeek >Welcome to geek heaven. >http://thinkgeek.com/sf >_______________________________________________ >Apc-aa-coders mailing list >Apc...@li... >https://lists.sourceforge.net/lists/listinfo/apc-aa-coders -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Jakub A. <jak...@se...> - 2003-03-10 21:24:28
|
My new approach was to send the not shown variables as notshown[ve4556ab....], which should then fill the default. See doc/anonym.html the last paragraph of Creating with the Wizard. Jakub > -----Original Message----- > From: apc...@li... > [mailto:apc...@li...] On Behalf > Of Honza Malik > Sent: Monday, March 10, 2003 7:17 PM > To: apc...@so... > Subject: Re: [Apc-aa-coders] Validation: Required + Default + > Show - willfixing this break anything? > > > I think that if you set Required, then the data should be > filled. If it is not filled, it is error. If you do not want > to generate error, you can easily set it as "Not Required". > > Honza > > On Po, 2003-03-10 at 08:02, Mitra wrote: > > Hi > > > > I've got an error being generated from an anonymous form > > > > The anonymous form loads into a slice, where Publish_Date is marked > > as Required & Show, > > > > However, the anonymous form does NOT have Publish_Date on > it, since I > > don't want anonymous users setting it. > > > > My thinking was that because Publish_Date has a Default set, it > > should set the default, but instead it generates an error. > > > > What do people think - should Required + Default mean to set the > > default, or generate an error? > > > > - Mitra > > > > -- > > Mitra Technology Consulting - www.mitra.biz - mi...@mi... > > 02-6684-8096 or 0414-648-0722 > > > > Life is a Mystery to be Lived, not a Problem to be Solved > > > > > > > > ------------------------------------------------------- > > This SF.net email is sponsored by: Etnus, makers of TotalView, The > > debugger > > for complex code. Debugging C/C++ programs can leave you > feeling lost and > > disoriented. TotalView can help you find your way. > Available on major UNIX > > and Linux platforms. Try it free. www.etnus.com > > _______________________________________________ > > Apc-aa-coders mailing list > > Apc...@li... > > https://lists.sourceforge.net/lists/listinfo/apc-aa-coders > > > > > > > ------------------------------------------------------- > This sf.net email is sponsored by:ThinkGeek > Welcome to geek heaven. > http://thinkgeek.com/sf > _______________________________________________ > Apc-aa-coders mailing list > Apc...@li... > https://lists.sourceforge.net/lists/listinfo/apc-aa-coders > |
From: Honza M. <hon...@ec...> - 2003-03-10 18:11:49
|
I think that if you set Required, then the data should be filled. If it is not filled, it is error. If you do not want to generate error, you can easily set it as "Not Required". Honza On Po, 2003-03-10 at 08:02, Mitra wrote: > Hi > > I've got an error being generated from an anonymous form > > The anonymous form loads into a slice, where Publish_Date is marked > as Required & Show, > > However, the anonymous form does NOT have Publish_Date on it, since I > don't want anonymous users setting it. > > My thinking was that because Publish_Date has a Default set, it > should set the default, but instead it generates an error. > > What do people think - should Required + Default mean to set the > default, or generate an error? > > - Mitra > > -- > Mitra Technology Consulting - www.mitra.biz - mi...@mi... > 02-6684-8096 or 0414-648-0722 > > Life is a Mystery to be Lived, not a Problem to be Solved > > > > ------------------------------------------------------- > This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger > for complex code. Debugging C/C++ programs can leave you feeling lost and > disoriented. TotalView can help you find your way. Available on major UNIX > and Linux platforms. Try it free. www.etnus.com > _______________________________________________ > Apc-aa-coders mailing list > Apc...@li... > https://lists.sourceforge.net/lists/listinfo/apc-aa-coders > |
From: Honza M. <hon...@ec...> - 2003-03-10 09:33:28
|
Yes, go ahead. Honza On Po, 2003-03-10 at 05:43, Mitra wrote: > Honza >=20 > I want to clarify >=20 > We agreed that any insert_fnc_xxx should set $err[field_id] on=20 > error e.g. $err[image.....1] =3D> "Wrong type of file" >=20 > Is that correct, I'm going to start correcting code and submitting=20 > to CVS so please say if this is not the agreed spec. >=20 > - Mitra >=20 >=20 > At 10:13 PM +1100 4/3/03, Mitra wrote: > >Any thoughts on this? How would we like to pass error results back=20 > >from one of the insert_fnc_xxx functions? > > > >- Mitra > > > > > >At 9:57 AM +1100 26/2/03, Mitra wrote: > >>Don't we need to define ONE of these ways, and then convert the=20 > >>existing functions to use it, I think the confusion is because the=20 > >>rules aren't defined so each coder has done it differently. > >> > >>For example insert_fnc_fil sets $err, but that is ignored. > >> > >>I would suggest that we need both errors and warnings, i.e. that a=20 > >>warning is set when an item *IS*created/edited, and errors are set=20 > >>when an item *IS NOT* created/edited. > >> > >>- Mitra > >> > >> > >>At 2:03 PM +0100 25/2/03, Honza Malik wrote: > >>>Hi Mitra, > >>> > >>> you are right, currently generated messages from insert_fnc_xxx > >>>functions are ignored - we do not use the return code. So, it is up to > >>>you, how to display the errors to user (direct displaying in > >>>StoreItem(), filling global $err[] array, creating new Error object, > >>>...). I do not prefer option 1. > >>> > >>>Regards, > >>> Honza > >>> > >>>On P=E1, 2003-02-21 at 22:51, Mitra wrote: > >>>> Honza > >>>> > >>>> How are errors SUPPOSED to be returned from insert_fnc_xxxx functio= ns, > >>>> > >>>> I see various places where things are done like return "xxxx" > >>>> > >>>> But ...the calling functions seem to ignore these errors, > >>>> > >>>> Specifically I'm trying to get errors generated inside insert_fnc_f= il > >>>> when trying and failing to do a Resize to propogate all the way bac= k > >>>> to the calling Item Manager screen, and I can't figure out how you > >>>> wanted this to work. > >>>> > >>>> - Mitra > >>>> > >>>> -- > >>>> Mitra Technology Consulting - www.mitra.biz - mi...@mi... > >>>> 02-6684-8096 or 0414-648-0722 > >>>> > >>>> Life is a Mystery to be Lived, not a Problem to be Solved > >>>> > >>>> > >>>> > >>>> ------------------------------------------------------- > >>>> This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. > >>>> The most comprehensive and flexible code editor you can use. > >>>> Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Tri= al. > >>>> www.slickedit.com/sourceforge > >>>> _______________________________________________ > >>>> Apc-aa-coders mailing list > >>>> Apc...@li... > >>>> https://lists.sourceforge.net/lists/listinfo/apc-aa-coders > >>>> > >>> > >>> > >>> > >>> > >>>------------------------------------------------------- > >>>This sf.net email is sponsored by:ThinkGeek > >>>Welcome to geek heaven. > >>>http://thinkgeek.com/sf > >>>_______________________________________________ > >>>Apc-aa-coders mailing list > >>>Apc...@li... > >>>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders > >> > >> > >>-- > >>Mitra Technology Consulting - www.mitra.biz - mi...@mi... > >>02-6684-8096 or 0414-648-0722 > >> > >>Life is a Mystery to be Lived, not a Problem to be Solved > > > > > >-- > >Mitra Technology Consulting - www.mitra.biz - mi...@mi... > >02-6684-8096 or 0414-648-0722=20 > > > >Life is a Mystery to be Lived, not a Problem to be Solved >=20 >=20 > --=20 > Mitra Technology Consulting - www.mitra.biz - mi...@mi... > 02-6684-8096 or 0414-648-0722=20 >=20 > Life is a Mystery to be Lived, not a Problem to be Solved |
From: Norbert B. <br...@ch...> - 2003-03-10 09:29:52
|
From: "Mitra" <mi...@ea...> > Ok - I found and fixed this problem, the code skipped over the case=20 > of the URL being specified, when it should have just stored it back=20 > to the item. Thanks Mitra. > Note - I notice, that if you enter a URL it does NOT generate=20 > thumbnails, I can't figure out how you would distinguish this case,=20 > from the case where its a URL of an already uploaded file. It was not our intention to resize images specified by URL, since it = would add unnecessary complications to the image resize function. This = functionality could be added later (might be useful for resizing of all = images - e.g. when changing layout of your site and need different image = dimensions). In that case the function would have to distinguish between = local (already uploaded image) and image stored on remote site. In case = of remote image it should have to decide whether to download it, then = download it, store localy and resize. norbert br...@ch... |
From: Mitra <mi...@ea...> - 2003-03-10 08:54:28
|
Hi Something seems to have changed, If I go to http://www.byronbayfm.org.au/apc-aa/admin/itemedit.php3?edit=1&encap=false&id=b8bfb5b72572cf14f9beb876d0d59046&change_id=c85a4a34ccbe0ce54c4306b5c32373b1&return_url=%2Fdraft.shtml%3Fi%3D26%26apc%3De1-26 Then I correctly get a login screen, but once I login I get http://www.byronbayfm.org.au/apc-aa/admin/index.php3?slice_id=c85a4a34ccbe0ce54c4306b5c32373b1&AA_CP_Session=8417cd6e26f9f5b67c88ba6636a81cd5&rXn=1 I.e. its dumped me into the Item Manager, when I was trying to get to itemedit.php3. Its not a permission problem, I'm the superuser, This used to work just fine, Anyone know how this got broken, or how to fix it? - Mitra -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-10 07:05:55
|
Hi I've got an error being generated from an anonymous form The anonymous form loads into a slice, where Publish_Date is marked as Required & Show, However, the anonymous form does NOT have Publish_Date on it, since I don't want anonymous users setting it. My thinking was that because Publish_Date has a Default set, it should set the default, but instead it generates an error. What do people think - should Required + Default mean to set the default, or generate an error? - Mitra -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-10 04:46:30
|
Honza I want to clarify We agreed that any insert_fnc_xxx should set $err[field_id] on error e.g. $err[image.....1] =3D> "Wrong type of file" Is that correct, I'm going to start correcting code and submitting to CVS so please say if this is not the agreed spec. - Mitra At 10:13 PM +1100 4/3/03, Mitra wrote: >Any thoughts on this? How would we like to pass error results back >from one of the insert_fnc_xxx functions? > >- Mitra > > >At 9:57 AM +1100 26/2/03, Mitra wrote: >>Don't we need to define ONE of these ways, and then convert the >>existing functions to use it, I think the confusion is because the >>rules aren't defined so each coder has done it differently. >> >>For example insert_fnc_fil sets $err, but that is ignored. >> >>I would suggest that we need both errors and warnings, i.e. that a >>warning is set when an item *IS*created/edited, and errors are set >>when an item *IS NOT* created/edited. >> >>- Mitra >> >> >>At 2:03 PM +0100 25/2/03, Honza Malik wrote: >>>Hi Mitra, >>> >>> you are right, currently generated messages from insert_fnc_xxx >>>functions are ignored - we do not use the return code. So, it is up to >>>you, how to display the errors to user (direct displaying in >>>StoreItem(), filling global $err[] array, creating new Error object, >>>...). I do not prefer option 1. >>> >>>Regards, >>> Honza >>> >>>On P=E1, 2003-02-21 at 22:51, Mitra wrote: >>>> Honza >>>> >>>> How are errors SUPPOSED to be returned from insert_fnc_xxxx functions, >>>> >>>> I see various places where things are done like return "xxxx" >>>> >>>> But ...the calling functions seem to ignore these errors, >>>> >>>> Specifically I'm trying to get errors generated inside insert_fnc_fil >>>> when trying and failing to do a Resize to propogate all the way back >>>> to the calling Item Manager screen, and I can't figure out how you >>>> wanted this to work. >>>> >>>> - Mitra >>>> >>>> -- >>>> Mitra Technology Consulting - www.mitra.biz - mi...@mi... >>>> 02-6684-8096 or 0414-648-0722 >>>> >>>> Life is a Mystery to be Lived, not a Problem to be Solved >>>> >>>> >>>> >>>> ------------------------------------------------------- >>>> This SF.net email is sponsored by: SlickEdit Inc. Develop an edge. >>>> The most comprehensive and flexible code editor you can use. >>>> Code faster. C/C++, C#, Java, HTML, XML, many more. FREE 30-Day Trial. >>>> www.slickedit.com/sourceforge >>>> _______________________________________________ >>>> Apc-aa-coders mailing list >>>> Apc...@li... >>>> https://lists.sourceforge.net/lists/listinfo/apc-aa-coders >>>> >>> >>> >>> >>> >>>------------------------------------------------------- >>>This sf.net email is sponsored by:ThinkGeek >>>Welcome to geek heaven. >>>http://thinkgeek.com/sf >>>_______________________________________________ >>>Apc-aa-coders mailing list >>>Apc...@li... >>>https://lists.sourceforge.net/lists/listinfo/apc-aa-coders >> >> >>-- >>Mitra Technology Consulting - www.mitra.biz - mi...@mi... >>02-6684-8096 or 0414-648-0722 >> >>Life is a Mystery to be Lived, not a Problem to be Solved > > >-- >Mitra Technology Consulting - www.mitra.biz - mi...@mi... >02-6684-8096 or 0414-648-0722 > >Life is a Mystery to be Lived, not a Problem to be Solved -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-10 04:05:53
|
I just did a CVS update, and it broke my sites, it needed a sql_update, I think because of the change of structure to cope with the slice_reading_password Please try and remember to announce when sql_update has to be run! - Mitra -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-10 03:56:06
|
Ok - I found and fixed this problem, the code skipped over the case of the URL being specified, when it should have just stored it back to the item. Note - I notice, that if you enter a URL it does NOT generate thumbnails, I can't figure out how you would distinguish this case, from the case where its a URL of an already uploaded file. - Mitra At 8:36 AM +1100 8/3/03, Mitra wrote: >is that on the current CVS, some changes were made there recently. > >- Mitra > >At 7:28 PM +0100 7/3/03, Norbert Brazda wrote: >>There is an error with editing item with file upload field. >> >>Try to upload a file into AA. Then open the same item and edit >>something (leave file upload intact). When you update the item, you >>loose information about previously uploaded file (url pointing the >>file is rewriten to blank). >> -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-10 01:55:58
|
Here is a list of functions defined multiple times - a few (especially those defined MANY times) are defined in Javasript and therefore ok, but the others are all multiply defined in PHP. 15 Myaddslashes 8 SelectVis 7 usr_test 7 usr_return_url 7 usr_global_variable 7 SubmitItems 7 SelectValue 7 OpenPreview 7 OpenFeedForm 7 MoveItems 7 MarkedActionGo 7 FeedAllItems 5 get 5 Cancel 4 validate 4 Submit 4 slice_new 4 GetUser 4 GetMembership 4 GetIDPerms 4 GetGroupMembers 4 GetGroup 4 FindUsers 4 FindGroups 4 DelUser 4 DelPermObject 4 DelPerm 4 DelGroupMember 4 DelGroup 4 ChangeUser 4 ChangePerm 4 ChangeGroup 4 AuthenticateUsername 4 AddUser 4 AddPermObject 4 AddPerm 4 AddGroupMember 4 AddGroup 3 xml_serialize 3 update 3 set 3 SendOkPage 3 SendErrorPage 3 send_emails 3 pageCount 3 new_id 3 navarray 3 huh 3 halt 3 GetViewInfo 3 GetObjectsPerms 3 GetIDsInfo 3 get_aamenus 3 Defaults 3 create_filter_text 3 countPages 3 checkBounds 3 Absolute 2 xmlUpdateItems 2 view 2 updateFieldsMapping 2 updateCategories 2 tquery 2 te_au_confirm 2 submitCommand 2 startElement 2 start 2 slice 2 showCollectionAddOns 2 SetRole 2 setFromArray 2 SelectGU_ID 2 RSS_restrict 2 rssfeeds 2 RestoreVariables 2 removeVariable 2 removeSpot 2 removeCondition 2 relogin_if 2 Relative 2 RealyDelete 2 PutSearchLog 2 processSlashes 2 pnavbar 2 onefeed 2 MyUrl 2 myQuery 2 my_die 2 move 2 ModW_str2arr 2 ModW_arr2str 2 map1field 2 L2sql_insert 2 itemIsDuplicate 2 initialize_filters 2 getValue 2 get_output_cached 2 get_output 2 getmicrotime 2 get_howoften_options 2 GetFiltered 2 GetCategoryIdFromValue 2 find_user_by_login 2 FindAlertsUserPermissions 2 FindAlertsFilterPermissions 2 fillForm 2 filepath 2 f 2 endslash 2 endElement 2 EnableClick 2 email_address 2 dquery 2 DeleteSlice 2 Delete 2 DeBackslash 2 CZDateToTimestamp 2 create_collection_contents 2 contentvalue 2 conditionMatches 2 command 2 checkData 2 charD 2 auth_validatelogin 2 auth_loginform 2 apcfeeds 2 AlertsPageBegin 2 alerts_email_headers 2 add_vars 2 addVariable 2 addInSequence 2 addCondition 2 addChoice 2 A2sql_update 2 A2sql_insert -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-08 22:43:37
|
I have appended the original message about aa_menus, If util.php3 is getting too big, it would be MUCH easier to split it up - util.php3 and utilcore.php3 and then require_once utilcore.php3 from util.php3, this would be much better than redefining functions. Could you upgrade to PHP 4.3, this and later versions are where we are seeing all the redefining problems. - Mitra At 8:45 PM +0100 8/3/03, Jakub Adamek wrote: >Mitra, > >you are very right. I didn't want to include the whole util.php3 >because of performance, but perhaps it is not as important. > >But about get_aamenus(): there is no reason why one script should >include several menu definitions. I didn't encounter this problem, >where was it? > >As to the PHP version: I am developing on 4.1.1. > >Jakub > >-----Original Message----- >From: apc...@li... >[mailto:apc...@li...] On Behalf Of Mitra >Sent: Friday, March 07, 2003 10:32 PM >To: apc...@so... >Subject: [Apc-aa-coders] Redefining functions > >Jakub - > >I'm pulling this to a separate thread since its not really connected >to the filler problems > >>the problem of defining new_id twice is fixed in CVS (if (! >>function_exists ("new_id"))). Can you perhaps do an update? I get >>always this error on refresh. >> > >We are seeing a lot of problems with multiply defined functions, l >ately - I think they are becoming visible because the latest PHP >doesn't allow redefining functions. > >It seems to me that we have a big weakness in apc-aa if we redefine >functions, take this example of new_id, the version in filler.php3 >is wrong, it misses a bug-fix that Honza made on the version in >util.php3. > >It also makes it really hard to find bugs because it is not always >clear which version of a function is being used. > >There was also an example reported to do with aa-menus (defined in >menu.php3 and modules/site/menu.php3) recently - a message on >1-march that was never dealt with. > >Instead of redefining new_id, wouldn't it have been better to >include util.php3, I've deleted the code from post2shtml.php3 and >added require_once util.php3 I've done this and resubmitting to CVS. > >Could someone (is site module Jakub or Honza?) fix aa_menus. > >I'd also suggest upgrading your version of PHP so that you see these >problems on your dev machine. > >- Mitra Here is the earlier message ..... >So what can we do - I'm not clear if Jakub is redeclaring the >function for a reason? I tried a couple of things - like >temporarily renaming the function in include/menu.php3 just while >the site page loaded and that just broke things. > >At 11:31 AM +0100 28/2/03, Honza Malik wrote: >>I tried it on our install. I moved our site module up and it works in >>both configurations. >> >>I think the problem could be in diffrerent versions of PHP. It seems, >>that new versions of PHP (>=3D4.3.0) do not allow redeclaration of >>functions (it was also the problem with gc() in PHPLib already reported >>in apc-aa-general). >> >>On P=E1, 2003-02-28 at 05:00, Mitra wrote: >> > The admin interface won't go to manage a site now, this seems to be >> > because get_aamenus is defined in both menu.php3 and >> > modules/site/menu.php3 >> > >> > its a strange bug, it works on one of my installations, but not the >> > other - they are both running the current CVS, only the data is >> > different. >> > >> > I think the main difference is that when you login to one you get a >> > slice, whereas on the other you get a site (alphabetical order) >> > >> > I'm not quite clear whether the name collision is deliberate, i.e. >> > redefining a function - or accidental >> > >> > Anyway, I think its a Jakub problem - and he's out this week I >> > understand? I can work around it on my machine, but this stops work > > if anyone else has a "site" as their alphabetically first slice. -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Jakub A. <jak...@se...> - 2003-03-08 19:46:13
|
Mitra, I have enhanced the comments in post2shtml.php3 and in anonym.xml, now it will be hopefully better comprehensible. Jakub -----Original Message----- From: apc...@li... [mailto:apc...@li...] On Behalf Of Mitra Sent: Thursday, March 06, 2003 11:25 PM To: Jakub Adamek; apc...@so... Subject: RE: [Apc-aa-coders] Forms and error handling At 10:32 PM +0100 6/3/03, Jakub Adamek wrote: Mitra, ad 3: I can not find the bug with StoreItem. Could you help me? Everything is working fine for me. I have commented the rows in again. Please could you try to comment out individual functions in event_handler.php3 (like AuthUpdateReaders etc.) so that I know which function caused troubles? Or could you give me some access to some pages? Ok - I will look into this deeper, I think I still have a form that will generate the problem if I uncomment those lines. ad 4: This was a new bug. Thanks for finding it. Fixed. ad 5: I have created an example in doc/script/show_result.php3 Thanks - that script is useful, ad 6: I will try to make the FAQ consistent with doc/anonym ad 8: I am not sure what was your problem. The wizard creates the code for a .shtml page. Of course the code is created by a PHP script. I changed a bit the documentation in doc/anonym to clarify this point. Where is this SHTML page created? When I run the wizard I get a PHP3 page, I choose the slice, SliceAdmin / Anon Form Wiz ; change the URL; Click Show Form and I get a screen anonym_wizard.php3 with NO SHTML that I can find. This is the code for the PHP3 page, not for the SHTML page? I hope doc/script/show_result.php3 will help you with the results page. I don't know why you need to create an anonymous form otherwise than with a .shtml page. Because the anonymous form is on "site" i.e. created with modules/site, the only .shtml is a page containing<!--#include site.php3?....-->, so I take the PHP generated and put it into the site module, the URL on success is just '?i=10' meaning to go to item 10, which would be the thankyou page, and then "i=11" for failure, but I can't figure out what to put into the failure page. I can't put a SHTML include there, or PHP, all I can really put there is something inside {....} and have stringexpand.php3 expand it. I COULD put an {include} here if I could figure out what to put inside it, but it would make much more sense to do it directly with a {...} IF I COULD FIGURE OUT HOW THE RESULT IS STORED. I think the SSI includes do most resemble the readfile() PHP function. You only need to pass the post2sthml_id parameter to the PHP scripts called by readfile(). Sorry, I don't understand what you mean here at all, could you give an example. How do I get this post2shtml_id parameter? I'm assuming it is generated by filler.php3 somehow? Is it appended to the err_url? Can I make a suggestion ..... When really complex stuff like this isbuilt, could you generate some ARCHITECTURE documentation, as well as the docs like anonym.html AND an example. Things that are obvious to the coder, just aren't obvious to someone else looking at it. For example in this case ..... we need to know. ...(this is just an example, I KNOW that I don't have it right, because I don't understand how this is working) 1: insert_fnc_xxx generate errors like $GLOBALS[err][headline........] = "This string is too long" 2: filler.php3 martials these and stores them in its own $err[validate] (NOTE THIS IS REUSE OF THE GLOBAL, THIS NEW $err HAS A DIFFERENT STRUCTURE FROM THE $err filled by insert_fnc_xxxx 3: The result is stored somewhere ... 4: The id parameter is passed back ... how? 4: fillform.php3 gets this parameter from the URL which is the id field of the xxxx table and so on ..... This documentation can be quite brief, but its crucial to being able to debug. Without something like this, its impossible to trace a bug back and know which step is doing it wrong, and there is a real danger that one coder will go in and "FIX" something which isn't a bug, and therefore break something else. - Mitra -----Original Message----- From: apc...@li... [mailto:apc...@li...] On Behalf Of Mitra Sent: Thursday, March 06, 2003 1:17 PM To: hon...@ec...; apc...@so... Subject: [Apc-aa-coders] Forms and error handling Hi Honza thanks for the Yahoo chat, at least I think we are getting closer to solving some of this mess. As I see it, we have at least 6 sets of bugs to deal with So there are at least x bugs 1: The insert_fnc_fil etc functions don't always set $err[xxx] but either return a value, or set $err (string) etc 2: Some validate functions return an error, even if there is not one - for example if you try and post an anonymous form NOT containing a publish date, to a slice where Publish_date is marked as required&show then it will generate an error, rather than using the default 3: StoreItem crashes when it calls the event code when running off an anonymous form I've commented that call out in the CVS version until someone (Jakub?) fixes the bug. 4: filler.php3 ALWAYS calls the err_url because $err is ALWAYS an array even if it contains just "success". This was probably never spotted since the wizard uses the same URL for both. I'm going to assume that the array is correct, and the code is wrong, since anonym.html mentions "success". 5: Insufficient documentation on how to create an error page that will display the error. See http://aa.ecn.cz/apc-aa-dev/doc/anonym.html. for some docs, but even after reading these I'm having difficulty figuring out how to build a simple page (to go in err_url) that displays the error from the $err array and prompts the user to fix the problem - its even harder since what I really want is to set err_url to "mysite.shtml?i=99" since this is all driven by the "site" module, so I have to understand what is happening in order to modify it to do what I need. 6: The Documentation there is i.e. anonym.html isn't linked into either doc/index.html or the FAQ, so in effect it doesn't exist! PLEASE PLEASE LINK ALL DOCUMENTATION SO SOMEONE CAN FIND IT AGAIN 7: The FAQ is inconsistent with anonym.html, i.e. http://apc-aa.sourceforge.net/faq/#anonymous still says to cut and paste from "Add Item" instead of using the wizard. 8: anonym.html says "This wizard creates a complete form with the SSI include of fillform.php3 necessary to edit items. The resulting form differs depending on whether Anonymous editing is allowed or not." That is not what it appears to do - it outputs a PHP form, with no SSI. This might sound trivial, but we lost at least a day or more of work trying to figure it out (without seeing anonym.htm) and then looking for why it didn't work properly. I'm going to start fixing some of these bugs tomorrow, so please say something if I'm missing something - especially with items 1,2 or 4 I'd appreciate some help with figuring out how to do the results page, ideally within a "site" i.e. from within PHP3, with no access to SHTML. I've introduced the concept of a current item in the site, (you can see this in site_bayfm.php3) using this might be the best mechanism to get at the posted data, but I'm not sure about that? - Mitra -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Jakub A. <jak...@se...> - 2003-03-08 19:46:07
|
Mitra, you are very right. I didn't want to include the whole util.php3 because of performance, but perhaps it is not as important. But about get_aamenus(): there is no reason why one script should include several menu definitions. I didn't encounter this problem, where was it? As to the PHP version: I am developing on 4.1.1. Jakub -----Original Message----- From: apc...@li... [mailto:apc...@li...] On Behalf Of Mitra Sent: Friday, March 07, 2003 10:32 PM To: apc...@so... Subject: [Apc-aa-coders] Redefining functions Jakub - I'm pulling this to a separate thread since its not really connected to the filler problems the problem of defining new_id twice is fixed in CVS (if (! function_exists ("new_id"))). Can you perhaps do an update? I get always this error on refresh. We are seeing a lot of problems with multiply defined functions, l ately - I think they are becoming visible because the latest PHP doesn't allow redefining functions. It seems to me that we have a big weakness in apc-aa if we redefine functions, take this example of new_id, the version in filler.php3 is wrong, it misses a bug-fix that Honza made on the version in util.php3. It also makes it really hard to find bugs because it is not always clear which version of a function is being used. There was also an example reported to do with aa-menus (defined in menu.php3 and modules/site/menu.php3) recently - a message on 1-march that was never dealt with. Instead of redefining new_id, wouldn't it have been better to include util.php3, I've deleted the code from post2shtml.php3 and added require_once util.php3 I've done this and resubmitting to CVS. Could someone (is site module Jakub or Honza?) fix aa_menus. I'd also suggest upgrading your version of PHP so that you see these problems on your dev machine. - Mitra -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-07 21:39:03
|
is that on the current CVS, some changes were made there recently. - Mitra At 7:28 PM +0100 7/3/03, Norbert Brazda wrote: >There is an error with editing item with file upload field. > >Try to upload a file into AA. Then open the same item and edit >something (leave file upload intact). When you update the item, you >loose information about previously uploaded file (url pointing the >file is rewriten to blank). > > > >norbert >br...@ch... > > >------------------------------------------------------- >This SF.net email is sponsored by: Etnus, makers of TotalView, The debugger >for complex code. Debugging C/C++ programs can leave you feeling lost and >disoriented. TotalView can help you find your way. Available on major UNIX >and Linux platforms. Try it free. www.etnus.com >_______________________________________________ >Apc-aa-coders mailing list >Apc...@li... >https://lists.sourceforge.net/lists/listinfo/apc-aa-coders -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-07 21:38:37
|
OK - I've updated and no errors are being generated now, although the item is not being added. I'll take more looks - won't be today - and see if I can track down the bug in StoreItem Can you give a short write up on the architecture, as suggested below? See separate message about redefining functions :-) - Mitra At 7:15 PM +0100 7/3/03, Jakub Adamek wrote: >Mitra, > >the problem of defining new_id twice is fixed in CVS (if (! >function_exists ("new_id"))). Can you perhaps do an update? I get >always this error on refresh. > >Jakub > >-----Original Message----- >From: Mitra [mailto:mi...@ea...] >Sent: Friday, March 07, 2003 6:18 AM >To: Jakub Adamek; apc...@so... >Subject: RE: [Apc-aa-coders] Forms and error handling > >P.S. > >I've figured out where fillform.php3 goes, in an HTML version, >though still have to figure out how to do this from within the site >module, I wasn't seeing it there at the top of the HTML generated by >the Form Wizard. > >The rest of the questions are still there .... > >I've updated CVS to latest version, but now there ARE TWO NEW BUGS, >and I see one or the other, with no consistency I can find as to >which happens. > >. You can see the anonymous form at >http://byronbayfm.org.au/draft.shtml?i=21 and its setup so that >there is no err_url defined so that I see the errors generated by an >extra "print_r($txt) in SendErrorPage.php3 there is also a print_r >of $GLOBALS to show exactly what the input in > >1: About half the time, I t complains slice_id is not defined > >2: The other half, It complains about redefinition of new_id, which >is defined in util.php3:323 and post2shtml.php3:88 > >hitting reload on that page generates these two unpredictably, it >always does one or the other .... > >- Mitra > >At 9:25 AM +1100 7/3/03, Mitra wrote: > >>At 10:32 PM +0100 6/3/03, Jakub Adamek wrote: >> >>>Mitra, >>> >> >> >>ad 3: I can not find the bug with StoreItem. Could you help me? >>Everything is working fine for me. I have commented the rows in >>again. Please could you try to comment out individual functions in >>event_handler.php3 (like AuthUpdateReaders etc.) so that I know >>which function caused troubles? Or could you give me some access to >>some pages? >> > >Ok - I will look into this deeper, I think I still have a form that >will generate the problem if I uncomment those lines. > > >>ad 4: This was a new bug. Thanks for finding it. Fixed. >> >ad 5: I have created an example in doc/script/show_result.php3 > > >Thanks - that script is useful, > > >>ad 6: I will try to make the FAQ consistent with doc/anonym >> >ad 8: I am not sure what was your problem. The wizard creates the >code for a .shtml page. Of course the code is created by a PHP >script. I changed a bit the documentation in doc/anonym to clarify >this point. > > >Where is this SHTML page created? When I run the wizard I get a PHP3 page, > > >I choose the slice, SliceAdmin / Anon Form Wiz ; change the URL; >Click Show Form and I get a screen anonym_wizard.php3 with NO >SHTML that I can find. This is the code for the PHP3 page, not for >the SHTML page? > > >> > >I hope doc/script/show_result.php3 will help you with the results >page. I don't know why you need to create an anonymous form >otherwise than with a .shtml page. > > >Because the anonymous form is on "site" i.e. created with >modules/site, the only .shtml is a page containing<!--#include >site.php3?....-->, so I take the PHP generated and put it into the >site module, the URL on success is just '?i=10' meaning to go to >item 10, which would be the thankyou page, and then "i=11" for >failure, but I can't figure out what to put into the failure page. > > >I can't put a SHTML include there, or PHP, all I can really put >there is something inside {....} and have stringexpand.php3 expand >it. I COULD put an {include} here if I could figure out what to put >inside it, but it would make much more sense to do it directly with >a {...} IF I COULD FIGURE OUT HOW THE RESULT IS STORED. > > >>I think the SSI includes do most resemble the readfile() PHP >>function. You only need to pass the post2sthml_id parameter to the >>PHP scripts called by readfile(). >> > >Sorry, I don't understand what you mean here at all, could you give >an example. How do I get this post2shtml_id parameter? I'm >assuming it is generated by filler.php3 somehow? Is it appended to >the err_url? > > >Can I make a suggestion ..... > > >When really complex stuff like this isbuilt, could you generate some >ARCHITECTURE documentation, as well as the docs like anonym.html AND >an example. Things that are obvious to the coder, just aren't >obvious to someone else looking at it. For example in this case >..... we need to know. ...(this is just an example, I KNOW that I >don't have it right, because I don't understand how this is working) > > >1: insert_fnc_xxx generate errors like >$GLOBALS[err][headline........] = "This string is too long" > >2: filler.php3 martials these and stores them in its own >$err[validate] (NOTE THIS IS REUSE OF THE GLOBAL, THIS NEW >$err HAS A DIFFERENT STRUCTURE FROM THE $err filled by >insert_fnc_xxxx > >3: The result is stored somewhere ... > >4: The id parameter is passed back ... how? > >4: fillform.php3 gets this parameter from the URL which is the id >field of the xxxx table > > >and so on ..... > > >This documentation can be quite brief, but its crucial to being able >to debug. Without something like this, its impossible to trace a bug >back and know which step is doing it wrong, and there is a real >danger that one coder will go in and "FIX" something which isn't a >bug, and therefore break something else. > > >- Mitra > > > > >>-----Original Message----- >>From: apc...@li... >>[mailto:apc...@li...] On Behalf Of >>Mitra >>Sent: Thursday, March 06, 2003 1:17 PM >>To: hon...@ec...; apc...@so... >>Subject: [Apc-aa-coders] Forms and error handling >> >>Hi Honza >> >> >>thanks for the Yahoo chat, at least I think we are getting closer >>to solving some of this mess. >> >> >>As I see it, we have at least 6 sets of bugs to deal with >> >> >>So there are at least x bugs >> >>1: The insert_fnc_fil etc functions don't always set $err[xxx] but >>either return a value, or set $err (string) etc >> >> >>2: Some validate functions return an error, even if there is not >>one - for example if you try and post an anonymous form NOT >>containing a publish date, to a slice where Publish_date is marked >>as required&show then it will generate an error, rather than using >>the default >> >> >>3: StoreItem crashes when it calls the event code when running off >>an anonymous form I've commented that call out in the CVS version >>until someone (Jakub?) fixes the bug. >> >> >>4: filler.php3 ALWAYS calls the err_url because $err is ALWAYS an >>array even if it contains just "success". This was probably never >>spotted since the wizard uses the same URL for both. I'm going to >>assume that the array is correct, and the code is wrong, since >>anonym.html mentions "success". >> >> >>5: Insufficient documentation on how to create an error page that >>will display the error. See >>http://aa.ecn.cz/apc-aa-dev/doc/anonym.html. for some docs, but >>even after reading these I'm having difficulty figuring out how to >>build a simple page (to go in err_url) that displays the error from >>the $err array and prompts the user to fix the problem - its even >>harder since what I really want is to set err_url to >>"mysite.shtml?i=99" since this is all driven by the "site" module, >>so I have to understand what is happening in order to modify it to >>do what I need. >> >> >>6: The Documentation there is i.e. anonym.html isn't linked into >>either doc/index.html or the FAQ, so in effect it doesn't exist! >>PLEASE PLEASE LINK ALL DOCUMENTATION SO SOMEONE CAN FIND IT AGAIN >> >> >>7: The FAQ is inconsistent with anonym.html, i.e. >>http://apc-aa.sourceforge.net/faq/#anonymous still says to cut and >>paste from "Add Item" instead of using the wizard. >> >> >>8: anonym.html says "This wizard creates a complete form with the >>SSI include of fillform.php3 necessary to edit items. The resulting >>form differs depending on whether Anonymous editing is allowed or >>not." That is not what it appears to do - it outputs a PHP form, >>with no SSI. >> >> >>This might sound trivial, but we lost at least a day or more of >>work trying to figure it out (without seeing anonym.htm) and then >>looking for why it didn't work properly. >> >> >>I'm going to start fixing some of these bugs tomorrow, so please >>say something if I'm missing something - especially with items 1,2 >>or 4 >> >> >> I'd appreciate some help with figuring out how to do the results >>page, ideally within a "site" i.e. from within PHP3, with no access >>to SHTML. I've introduced the concept of a current item in the >>site, (you can see this in site_bayfm.php3) using this might be the >>best mechanism to get at the posted data, but I'm not sure about >>that? >> >> >>- Mitra >> >> >>-- >> >>Mitra Technology Consulting - www.mitra.biz - mi...@mi... >> >>02-6684-8096 or 0414-648-0722 >> >> >>Life is a Mystery to be Lived, not a Problem to be Solved >> > > >-- > >Mitra Technology Consulting - www.mitra.biz - mi...@mi... >02-6684-8096 or 0414-648-0722 > >Life is a Mystery to be Lived, not a Problem to be Solved > > > >-- >Mitra Technology Consulting - www.mitra.biz - mi...@mi... >02-6684-8096 or 0414-648-0722 > >Life is a Mystery to be Lived, not a Problem to be Solved -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Mitra <mi...@ea...> - 2003-03-07 21:38:25
|
Jakub - I'm pulling this to a separate thread since its not really connected to the filler problems >the problem of defining new_id twice is fixed in CVS (if (! >function_exists ("new_id"))). Can you perhaps do an update? I get >always this error on refresh. We are seeing a lot of problems with multiply defined functions, l ately - I think they are becoming visible because the latest PHP doesn't allow redefining functions. It seems to me that we have a big weakness in apc-aa if we redefine functions, take this example of new_id, the version in filler.php3 is wrong, it misses a bug-fix that Honza made on the version in util.php3. It also makes it really hard to find bugs because it is not always clear which version of a function is being used. There was also an example reported to do with aa-menus (defined in menu.php3 and modules/site/menu.php3) recently - a message on 1-march that was never dealt with. Instead of redefining new_id, wouldn't it have been better to include util.php3, I've deleted the code from post2shtml.php3 and added require_once util.php3 I've done this and resubmitting to CVS. Could someone (is site module Jakub or Honza?) fix aa_menus. I'd also suggest upgrading your version of PHP so that you see these problems on your dev machine. - Mitra -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |
From: Norbert B. <br...@ch...> - 2003-03-07 18:20:40
|
There is an error with editing item with file upload field. Try to upload a file into AA. Then open the same item and edit something = (leave file upload intact). When you update the item, you loose = information about previously uploaded file (url pointing the file is = rewriten to blank). norbert br...@ch... |
From: Norbert B. <br...@ch...> - 2003-03-07 18:19:56
|
There is an error with editing item with file upload field. Try to upload a file into AA. Then open the same item and edit something = (leave file upload intact). When you update the item, you loose = information about previously uploaded file (url pointing the file is = rewriten to blank). norbert br...@ch... |
From: Jakub A. <jak...@se...> - 2003-03-07 18:15:52
|
Mitra, the problem of defining new_id twice is fixed in CVS (if (! function_exists ("new_id"))). Can you perhaps do an update? I get always this error on refresh. Jakub -----Original Message----- From: Mitra [mailto:mi...@ea...] Sent: Friday, March 07, 2003 6:18 AM To: Jakub Adamek; apc...@so... Subject: RE: [Apc-aa-coders] Forms and error handling P.S. I've figured out where fillform.php3 goes, in an HTML version, though still have to figure out how to do this from within the site module, I wasn't seeing it there at the top of the HTML generated by the Form Wizard. The rest of the questions are still there .... I've updated CVS to latest version, but now there ARE TWO NEW BUGS, and I see one or the other, with no consistency I can find as to which happens. . You can see the anonymous form at http://byronbayfm.org.au/draft.shtml?i=21 and its setup so that there is no err_url defined so that I see the errors generated by an extra "print_r($txt) in SendErrorPage.php3 there is also a print_r of $GLOBALS to show exactly what the input in 1: About half the time, I t complains slice_id is not defined 2: The other half, It complains about redefinition of new_id, which is defined in util.php3:323 and post2shtml.php3:88 hitting reload on that page generates these two unpredictably, it always does one or the other .... - Mitra At 9:25 AM +1100 7/3/03, Mitra wrote: At 10:32 PM +0100 6/3/03, Jakub Adamek wrote: Mitra, ad 3: I can not find the bug with StoreItem. Could you help me? Everything is working fine for me. I have commented the rows in again. Please could you try to comment out individual functions in event_handler.php3 (like AuthUpdateReaders etc.) so that I know which function caused troubles? Or could you give me some access to some pages? Ok - I will look into this deeper, I think I still have a form that will generate the problem if I uncomment those lines. ad 4: This was a new bug. Thanks for finding it. Fixed. ad 5: I have created an example in doc/script/show_result.php3 Thanks - that script is useful, ad 6: I will try to make the FAQ consistent with doc/anonym ad 8: I am not sure what was your problem. The wizard creates the code for a .shtml page. Of course the code is created by a PHP script. I changed a bit the documentation in doc/anonym to clarify this point. Where is this SHTML page created? When I run the wizard I get a PHP3 page, I choose the slice, SliceAdmin / Anon Form Wiz ; change the URL; Click Show Form and I get a screen anonym_wizard.php3 with NO SHTML that I can find. This is the code for the PHP3 page, not for the SHTML page? I hope doc/script/show_result.php3 will help you with the results page. I don't know why you need to create an anonymous form otherwise than with a .shtml page. Because the anonymous form is on "site" i.e. created with modules/site, the only .shtml is a page containing<!--#include site.php3?....-->, so I take the PHP generated and put it into the site module, the URL on success is just '?i=10' meaning to go to item 10, which would be the thankyou page, and then "i=11" for failure, but I can't figure out what to put into the failure page. I can't put a SHTML include there, or PHP, all I can really put there is something inside {....} and have stringexpand.php3 expand it. I COULD put an {include} here if I could figure out what to put inside it, but it would make much more sense to do it directly with a {...} IF I COULD FIGURE OUT HOW THE RESULT IS STORED. I think the SSI includes do most resemble the readfile() PHP function. You only need to pass the post2sthml_id parameter to the PHP scripts called by readfile(). Sorry, I don't understand what you mean here at all, could you give an example. How do I get this post2shtml_id parameter? I'm assuming it is generated by filler.php3 somehow? Is it appended to the err_url? Can I make a suggestion ..... When really complex stuff like this isbuilt, could you generate some ARCHITECTURE documentation, as well as the docs like anonym.html AND an example. Things that are obvious to the coder, just aren't obvious to someone else looking at it. For example in this case ..... we need to know. ...(this is just an example, I KNOW that I don't have it right, because I don't understand how this is working) 1: insert_fnc_xxx generate errors like $GLOBALS[err][headline........] = "This string is too long" 2: filler.php3 martials these and stores them in its own $err[validate] (NOTE THIS IS REUSE OF THE GLOBAL, THIS NEW $err HAS A DIFFERENT STRUCTURE FROM THE $err filled by insert_fnc_xxxx 3: The result is stored somewhere ... 4: The id parameter is passed back ... how? 4: fillform.php3 gets this parameter from the URL which is the id field of the xxxx table and so on ..... This documentation can be quite brief, but its crucial to being able to debug. Without something like this, its impossible to trace a bug back and know which step is doing it wrong, and there is a real danger that one coder will go in and "FIX" something which isn't a bug, and therefore break something else. - Mitra -----Original Message----- From: apc...@li... [mailto:apc...@li...] On Behalf Of Mitra Sent: Thursday, March 06, 2003 1:17 PM To: hon...@ec...; apc...@so... Subject: [Apc-aa-coders] Forms and error handling Hi Honza thanks for the Yahoo chat, at least I think we are getting closer to solving some of this mess. As I see it, we have at least 6 sets of bugs to deal with So there are at least x bugs 1: The insert_fnc_fil etc functions don't always set $err[xxx] but either return a value, or set $err (string) etc 2: Some validate functions return an error, even if there is not one - for example if you try and post an anonymous form NOT containing a publish date, to a slice where Publish_date is marked as required&show then it will generate an error, rather than using the default 3: StoreItem crashes when it calls the event code when running off an anonymous form I've commented that call out in the CVS version until someone (Jakub?) fixes the bug. 4: filler.php3 ALWAYS calls the err_url because $err is ALWAYS an array even if it contains just "success". This was probably never spotted since the wizard uses the same URL for both. I'm going to assume that the array is correct, and the code is wrong, since anonym.html mentions "success". 5: Insufficient documentation on how to create an error page that will display the error. See http://aa.ecn.cz/apc-aa-dev/doc/anonym.html. for some docs, but even after reading these I'm having difficulty figuring out how to build a simple page (to go in err_url) that displays the error from the $err array and prompts the user to fix the problem - its even harder since what I really want is to set err_url to "mysite.shtml?i=99" since this is all driven by the "site" module, so I have to understand what is happening in order to modify it to do what I need. 6: The Documentation there is i.e. anonym.html isn't linked into either doc/index.html or the FAQ, so in effect it doesn't exist! PLEASE PLEASE LINK ALL DOCUMENTATION SO SOMEONE CAN FIND IT AGAIN 7: The FAQ is inconsistent with anonym.html, i.e. http://apc-aa.sourceforge.net/faq/#anonymous still says to cut and paste from "Add Item" instead of using the wizard. 8: anonym.html says "This wizard creates a complete form with the SSI include of fillform.php3 necessary to edit items. The resulting form differs depending on whether Anonymous editing is allowed or not." That is not what it appears to do - it outputs a PHP form, with no SSI. This might sound trivial, but we lost at least a day or more of work trying to figure it out (without seeing anonym.htm) and then looking for why it didn't work properly. I'm going to start fixing some of these bugs tomorrow, so please say something if I'm missing something - especially with items 1,2 or 4 I'd appreciate some help with figuring out how to do the results page, ideally within a "site" i.e. from within PHP3, with no access to SHTML. I've introduced the concept of a current item in the site, (you can see this in site_bayfm.php3) using this might be the best mechanism to get at the posted data, but I'm not sure about that? - Mitra -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved -- Mitra Technology Consulting - www.mitra.biz - mi...@mi... 02-6684-8096 or 0414-648-0722 Life is a Mystery to be Lived, not a Problem to be Solved |