[Apache-dispatch-devel] SF.net SVN: apache-dispatch: [40] trunk

[<phr...@us...>]

Revision: 40
Author:   phred_moyer
Date:     2006-06-06 23:44:42 -0700 (Tue, 06 Jun 2006)
ViewCVS:  http://svn.sourceforge.net/apache-dispatch/?rev=40&view=rev

Log Message:
-----------
- use need_lwp() rather than have_lwp() so that tests are skipped if LWP is not
  installed.

Modified Paths:
--------------
    trunk/Makefile.PL
    trunk/t/01plain.t
    trunk/t/02extras.t
    trunk/t/03filter.t
Modified: trunk/Makefile.PL
===================================================================
--- trunk/Makefile.PL	2006-06-06 06:54:28 UTC (rev 39)
+++ trunk/Makefile.PL	2006-06-07 06:44:42 UTC (rev 40)
@@ -10,8 +10,7 @@
 
 print STDERR "Using mod_perl/$mp_ver\n\n";
 
-my %prereq = ('Apache::Test' => "1.23",
-			  'LWP::UserAgent' => 0);
+my %prereq = ('Apache::Test' => "1.23");
 
 my %makefile_params = (
                        'VERSION'   => '0.10',

Modified: trunk/t/01plain.t
===================================================================
--- trunk/t/01plain.t	2006-06-06 06:54:28 UTC (rev 39)
+++ trunk/t/01plain.t	2006-06-07 06:44:42 UTC (rev 40)
@@ -4,11 +4,11 @@
 use Apache::Test;
 use Apache::TestRequest;
 
-plan tests => 4, \&have_lwp;
+plan tests => 4, \&need_lwp;
 
 # Test Apache2::Foo->dispatch_index
 my $uri = '/plain';
-ok(GET_OK $uri, 'test passed');
+ok GET_OK $uri;
 
 # Test Apache2::Foo->dispatch_foo
 $uri = '/plain/foo';

Modified: trunk/t/02extras.t
===================================================================
--- trunk/t/02extras.t	2006-06-06 06:54:28 UTC (rev 39)
+++ trunk/t/02extras.t	2006-06-07 06:44:42 UTC (rev 40)
@@ -4,7 +4,7 @@
 use Apache::Test;
 use Apache::TestRequest;
 
-plan tests => 5, \&have_lwp;
+plan tests => 5;#, \&need_lwp;
 
 my $uri = '/extras';
 my $res = GET $uri;

Modified: trunk/t/03filter.t
===================================================================
--- trunk/t/03filter.t	2006-06-06 06:54:28 UTC (rev 39)
+++ trunk/t/03filter.t	2006-06-07 06:44:42 UTC (rev 40)
@@ -9,10 +9,10 @@
 my $version = `$httpd -v`;
 
 if ($version =~ m/Apache\/2/) {
-    plan skip_all => "Filter test irrelevant on mod_perl2";
+    plan skip_all => "Filtering not yet implemented in Apache2::Dispatch";
 }
 else {
-    plan tests => 2, \&have_lwp;
+    plan tests => 2, \&need_lwp;
 }
 
 my $url = '/filtered/foo';


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.