Menu

#57 Wrong Glib::RefPtr comparison

2.9
closed
None
2016-09-30
2016-09-30
No

When compiling with gcc-6 (or the new glib version) on Debian testing, Glib::RefPtr cannot be compared anymore to an int (0) like:

        Glib::RefPtr<Gdk::Window> window = get_window();
            if(window != 0 && get_width() > 0 && get_height() > 0)
            ...

Instead, this should be replaced with if (window && get_width...).
The attached patch fixes all these cases so than AOFlagger may be compiled on a recent Debian system.

1 Attachments

Related

Wiki: changelog-2.9.0

Discussion

  • André Offringa

    André Offringa - 2016-09-30
     
  • André Offringa

    André Offringa - 2016-09-30

    Excellent, thanks for the patch. I've committed it to the repository and the fix will be part of aoflagger 2.9.

     
  • André Offringa

    André Offringa - 2016-09-30
    • status: open --> closed
    • assigned_to: André Offringa
    • Milestone: 2.8 --> 2.9