Re: [Aoetools-discuss] [PATCH] Implement an offset option for vbladed

[Christoph B. <sou...@ma...>]

Ed Cashin wrote...

> I was thinking of something like this:
> 
>   https://github.com/ecashin/vblade/commit/ca2dbda0a35ba686c0ed64e109748129c510fa90
> 
> Please let me know if that looks OK to you.

Looks good. One final remark, rather nitpicking. You deny length == 0
which is the right thing. It is however possible to create a zero
size export by setting offset to the size of the exported file, and a
change comparison "size <= offset" would catch that.

By the way, the initiator, at least if it's a recent Linux kernel, is 
not very impressed by such a device.

    Christoph