Re: [Ant-contrib-developers] Suggested patch for net/sf/antcontrib/cpptasks/CUtil.java

[Curt A. <ca...@ho...>]

Mirko Raner wrote:

> Hi all,
>
> I am currently in the process of writing a cpptasks compiler adapter 
> that needs to run under Windows as well as Linux and Solaris.
> I noticed that the function CUtil.getExecutableLocation(...) uses a 
> semicolon as hardcoded path separator and thus only works properly 
> under Windows.
> The following patch for CUtil.java should fix the problem:
>
> 416c416
> <         File[] envPath = CUtil.getPathFromEnvironment("path",";");
> ---
> >         File[] envPath = CUtil.getPathFromEnvironment("path", 
> File.pathSeparator);
>
> I am not quite sure whether this is the right format for submitting 
> suggestions, so let me know if there is anything else that I need to 
> do in order to have this fixed. Do I need to send in a test case as well?
>
> Thanks,
>
> Mirko


Looks good, I'll commit it (barring any objections) my next cpptasks 
session.