[Ant-contrib-developers] [ ant-contrib-Bugs-1820975 ] Fails in <for parallel="true" keepgoing="false">

[SourceForge.net <no...@so...>]

Bugs item #1820975, was opened at 2007-10-26 15:01
Message generated for change (Comment added) made by clheiny
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=416920&aid=1820975&group_id=36177

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: logic
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: Fails in <for parallel="true" keepgoing="false">

Initial Comment:
<for parallel="true" keepgoing="false"> does not stop execution if one of the threads fails.
<parallel> implementation does not use failonany="true" in this case.


----------------------------------------------------------------------

Comment By: Christopher Heiny (clheiny)
Date: 2008-03-05 13:38

Message:
Logged In: YES 
user_id=117164
Originator: NO

Hmmmm.  I won't be able to look at this until next week, but my guess now
is that it should be easy to remedy.

----------------------------------------------------------------------

Comment By: Nobody/Anonymous (nobody)
Date: 2008-03-05 12:05

Message:
Logged In: NO 

clheiny,
There is an error in the code:

parallel failonany should use reverted ForTask keepgoing value, i.e. if
keepgoing is false failonany should be true
Thanks. Andrey.

----------------------------------------------------------------------

Comment By: Christopher Heiny (clheiny)
Date: 2007-11-06 15:00

Message:
Logged In: YES 
user_id=117164
Originator: NO

I've got a patch against trunk for this, but don't see a button for
attaching the patch file to the bug.  It's trivial, so here it is:


Index: src/main/java/net/sf/antcontrib/logic/ForTask.java
===================================================================
--- src/main/java/net/sf/antcontrib/logic/ForTask.java  (revision 146)
+++ src/main/java/net/sf/antcontrib/logic/ForTask.java  (working copy)
@@ -212,6 +212,7 @@
     public void execute() {
         if (parallel) {
             parallelTasks = (Parallel)
getProject().createTask("parallel");
+            parallelTasks.setFailOnAny(keepgoing);
             if (threadCount != null) {
                 parallelTasks.setThreadCount(threadCount.intValue());
             }


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=416920&aid=1820975&group_id=36177