may be the cause of this bug. Replacing $timeout with settimeout fixes the issues, however I think consumers would expect a digest after their code. So ideally we should cancel the timeout, hopefully this will fix the issue.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: dwmkerr
I am working on a simple application to show how to resolve memory leaks and during development of that application found that:
https://github.com/dwmkerr/angular-modal-service/blob/master/src/angular-modal-service.js#L90
may be the cause of this bug. Replacing
$timeoutwithsettimeoutfixes the issues, however I think consumers would expect a digest after their code. So ideally we shouldcancelthe timeout, hopefully this will fix the issue.View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Ticket changed by: dwmkerr
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: matthiasdailey-ccri
Here's a permalink, since that link to master has changed over time:
https://github.com/dwmkerr/angular-modal-service/blob/315b7bbbde5a555ba8c49271520cf835963d330d/src/angular-modal-service.js#L90