#23 Fix for not properly closed modal

[Anonymous]

Originally created by: siready

After modal was removed from DOM, there was still possibility that "modal-open" class was left on body element. It happened only in case if modal buttons didn't have data-dismiss="modal" attribute. This fix triggers normal bootstrap hiding process and removes element from DOM afterwards.

[Anonymous]

Originally posted by: coveralls

Coverage decreased (-3.7%) when pulling 2bad891cf7848e49c2cac7caf7b649a86715406b on siready:master into 716163b838908fcc3d9dcac218f257be976170a5 on dwmkerr:master.

[Anonymous]

Originally posted by: siready

Tests are failing obviously. Could you please verify and check the problem? Then we can tackle tests.

[Anonymous]

Originally posted by: dwmkerr

Hi @siready the problem with this code is that it assumes that every modal is a bootstrap modal, and the library is designed to be agnostic as to what types of modal are being used. The implication is that any bootstrap specific functionality should be implemented by consumers of the library rather than the library itself.

The code however is useful, so it might be worth adding to the documentation as a tip for bootstrap users, what do you think?

[Anonymous]

Ticket changed by: siready

• status: open --> closed

[Anonymous]

Originally posted by: siready

You're right! That approach was wrong, but at the time I wasn't aware it's supposed to be vendor agnostic.

I eventually settled with closing the dialog with the following code in modal controller:

$element.modal('hide');
$element.one('hidden.bs.modal', function(){
    close();
});

[Anonymous]

Originally posted by: dwmkerr

I like it, I'll write it up!