Menu ▾ ▴

#188 On Location Change don't pass event as result

open
nobody
None
2016-12-12
2016-12-09
Anonymous
No

Originally created by: SergeyCherman

I think when closing the modal on location change it shouldn't pass event as the result .

Discussion

  • Comment has been marked as spam. 
    Undo

    View and moderate all "tickets Discussion" comments posted by this user

    Mark all as spam, and block user from posting to "Tickets"

    Anonymous

    Anonymous - 2016-12-09

    Originally posted by: coveralls

    Coverage Status

    Coverage increased (+0.2%) to 86.154% when pulling 632127854adc2f96396cc780b494de99853ea75e on SergeyCherman:patch-1 into 2c07464da8b661d6721827809f61e1870733bcd6 on dwmkerr:master.

     
  • Comment has been marked as spam. 
    Undo

    View and moderate all "tickets Discussion" comments posted by this user

    Mark all as spam, and block user from posting to "Tickets"

    Anonymous

    Anonymous - 2016-12-11

    Originally posted by: unkillbob

    I wonder if it would make more sense to reject the close and closed promises in this case? The modal is being closed by an external force (the location change), it feels more like a "cancel" than a successful closing of the modal to me.

     
  • Comment has been marked as spam. 
    Undo

    View and moderate all "tickets Discussion" comments posted by this user

    Mark all as spam, and block user from posting to "Tickets"

    Anonymous

    Anonymous - 2016-12-12

    Originally posted by: SergeyCherman

    I can see it both ways, however it's possible users of the service have one function for ok/cancel which then uses the function input to decide what to do. In this case if a user has any cleanup logic on modal close it wouldn't run.
    Currently reject doesn't fire unless the service isn't being used correct, so it would be a change for service users as they probably don't have logic for the reject case.

     

Log in to post a comment.