change the order of modalScope destroy

Modal service for AngularJS - supports creating popups and modals via a service.

Brought to you by: evanfcrane

#187 change the order of modalScope destroy

Status: open

Owner: nobody

Labels: None

Updated: 2017-03-06

Created: 2016-12-07

Creator: Anonymous

Private: No

Originally created by: kernowjoe

To stop any form validation errors from a non existent form when the scope still exists, destroy the scope first and then let $animate remove the template

Discussion

Comment has been marked as spam.
Undo

View and moderate all "tickets Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Tickets"

Anonymous - 2016-12-07

Originally posted by: coveralls

Coverage increased (+1.6%) to 87.5% when pulling 49dff27b6753f70e455a4689d50c1652a7db2602 on kernowjoe:removeScopeBeforeTemplate into 2c07464da8b661d6721827809f61e1870733bcd6 on dwmkerr:master.

*Originally posted by:* [coveralls](https://github.com/coveralls) [![Coverage Status](https://coveralls.io/builds/9172248/badge)](https://coveralls.io/builds/9172248) Coverage increased (+1.6%) to 87.5% when pulling **49dff27b6753f70e455a4689d50c1652a7db2602 on kernowjoe:removeScopeBeforeTemplate** into **2c07464da8b661d6721827809f61e1870733bcd6 on dwmkerr:master**.

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Comment has been marked as spam.
Undo

View and moderate all "tickets Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Tickets"

Anonymous - 2016-12-09

Originally posted by: SergeyCherman

Thanks for this! I was in the middle of finding the issue as well.

*Originally posted by:* [SergeyCherman](https://github.com/SergeyCherman) Thanks for this! I was in the middle of finding the issue as well.

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Comment has been marked as spam.
Undo

View and moderate all "tickets Discussion" comments posted by this user

Mark all as spam, and block user from posting to "Tickets"

Anonymous - 2017-03-06

Originally posted by: warjohn123

Are there no plans of merging this?

*Originally posted by:* [warjohn123](https://github.com/warjohn123) Are there no plans of merging this?

Add attachments
Cancel
You seem to have CSS turned off. Please don't fill out this field.

You seem to have CSS turned off. Please don't fill out this field.

New Attachment:

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.