LocationChangeSuccess event registration to be configurable
Modal service for AngularJS - supports creating popups and modals via a service.
Brought to you by:
evanfcrane
Menu
▾
▴
#181 LocationChangeSuccess event registration to be configurable
open
nobody
None
2016-12-06
2016-10-16
Anonymous
No
Originally created by: smalbs
There's two issues (#172 and [#164]) where the locationChangeSuccess event listener is registered immediately causing a problem for any pending route changes. This update allows the locationChangeSuccess to be configurable as a part of he showModal options:
- default (no option) will register listener immedieately
- false will disable event registration
- number >= 0 will register event after delay
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: coveralls
Coverage increased (+1.02%) to 86.957% when pulling f007b3e267a2111a3c08b43895b44ac2db9dede7 on samalbert:master into 2c07464da8b661d6721827809f61e1870733bcd6 on dwmkerr:master.
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: pdemilly
I just tried your branch and it fixed the problem I was having. Thanks.
+1 to merge it
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: smalbs
@pdemilly Glad I could help!
View and moderate all "tickets Discussion" comments posted by this user
Mark all as spam, and block user from posting to "Tickets"
Originally posted by: SergeyCherman
@dwmkerr can this be merged and a version bump be made?