From: Alexander N. <ale...@gm...> - 2011-02-11 01:43:50
|
>Hmmm... Thanks for the reply, but why don't you just fwd it to the ML >instead? :) Oh, PEBKAC! Reply button set you as For: instead of ML. I'll copy the reply here: ----- Hey viv :) > Thanks for making the diff, and VGJ!! However, I'm _really_ > *extremely* busy with other stuff at the lab these days (it's annoying > when several top-priority urgent things pop up at the same time ☹) > so... I am sorry... I probably can't review it until this weekend ☹ No rush, take your time ;) > The memleak might be because KKRT has msnp18 enabled. You can try that > too. I especially want to know which revision started it. Ok, I'll make more tests with p18 and check what rev they started and ended (if I can reproduce them). > removed and readded whitespace??... Did you even know about the -w /me never did man diff :$ > option in diff and -l option in patch? They are "ignore whitespace" :facepalm: > between current trunk and your patched gui.tcl, perform a diff -w -C3 > (we do need three lines of context), and use that instead. (I know you > did a lot of work already, but could you _please_ do that too? I don't > think it would take more than 5 minutes :$) Yes!! I needed something like that!! I am almost sure that I merged everything fine, but it will be OK to check it again, just to be sure. Regards! :) ------ -- alexandernst |