[Amsn-commits] SF.net SVN: amsn:[11108] trunk/amsn/utils/linux/capture/capture.c

[<kak...@us...>]

Revision: 11108
          http://amsn.svn.sourceforge.net/amsn/?rev=11108&view=rev
Author:   kakaroto
Date:     2009-03-24 16:10:22 +0000 (Tue, 24 Mar 2009)

Log Message:
-----------
Fix a crash in capture extension, we shouldn't check attr->min/max unless attr is != NULL.. also, we always return TCL_OK now, no need for a TCL_ERROR

Modified Paths:
--------------
    trunk/amsn/utils/linux/capture/capture.c

Modified: trunk/amsn/utils/linux/capture/capture.c
===================================================================
--- trunk/amsn/utils/linux/capture/capture.c	2009-03-24 10:05:19 UTC (rev 11107)
+++ trunk/amsn/utils/linux/capture/capture.c	2009-03-24 16:10:22 UTC (rev 11108)
@@ -870,15 +870,10 @@
   // Get the ng_attribute struct from the attribute id
   attr = ng_attr_byid(&(capItem->dev), attribute);
   
-  if (new_value > attr->max || new_value < attr->min) {
-    Tcl_SetResult(interp, "Value out of range" , TCL_STATIC);
-    return TCL_ERROR;
-  }
-
   // Set attribute value using attribute->write proc...
   if (attr != NULL) {
-      if (new_value != -1)
-        attr->write(attr, new_value);
+    if (new_value >= attr->min && new_value <= attr->max)
+      attr->write(attr, new_value);
   }
   
   return TCL_OK;


This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.