Re: [Amsn-devel] [Amsn-commits] SF.net SVN: amsn: [7895] trunk/amsn/protocol.tcl

[Sander H. <sa...@ho...>]

lol, it was actually a TODO item

On Fri, 2007-02-02 at 11:29 -0800, kak...@us... wrote:
> Revision: 7895
>           http://svn.sourceforge.net/amsn/?rev=7895&view=rev
> Author:   kakaroto
> Date:     2007-02-02 11:29:39 -0800 (Fri, 02 Feb 2007)
> 
> Log Message:
> -----------
> This should fix the bug reported here : http://www.amsn-project.net/forums/viewtopic.php?t=2465
> Now we check that P2P message are indeed sent to us before processing them. This avoid the bugs when a DP is changed/requested/p2p-downloaded when in a multichat.
> Special thanks to Karel who found the possible cause and to all the testers : NWM, Tjikkun, Karel, Vivia, llona, burger, Alvaro, who else was there ? :p
> 
> Modified Paths:
> --------------
>     trunk/amsn/protocol.tcl
> 
> Modified: trunk/amsn/protocol.tcl
> ===================================================================
> --- trunk/amsn/protocol.tcl	2007-02-02 18:07:18 UTC (rev 7894)
> +++ trunk/amsn/protocol.tcl	2007-02-02 19:29:39 UTC (rev 7895)
> @@ -4207,12 +4207,14 @@
>  				}
>  			}
>  			application/x-msnmsgrp2p {
> -				#TODO: check if header P2P-Dest == our own nick. If not, discard message
> -				set p2pmessage [P2PMessage create %AUTO%]
> -				$p2pmessage createFromMessage $message
> -				::MSNP2P::ReadData $p2pmessage $chatid
> -				#status_log [$p2pmessage toString 1]
> -				catch { $p2pmessage destroy }
> +				set dest [$message getHeader "P2P-Dest"]
> +				if { $dest == [::config::getKey login] } {
> +					set p2pmessage [P2PMessage create %AUTO%]
> +					$p2pmessage createFromMessage $message
> +					::MSNP2P::ReadData $p2pmessage $chatid
> +					#status_log [$p2pmessage toString 1]
> +					catch { $p2pmessage destroy }
> +				}
>  			}
>  
>  			text/x-mms-emoticon -
> 
> 
> This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site.
> 
> -------------------------------------------------------------------------
> Using Tomcat but need to do more? Need to support web services, security?
> Get stuff done quickly with pre-integrated technology to make your job easier.
> Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
> http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
> _______________________________________________
> Amsn-commits mailing list
> Ams...@li...
> https://lists.sourceforge.net/lists/listinfo/amsn-commits
>