Menu

#4 DERGB duplicate redundant function

1.0
closed
None
2015-01-23
2015-01-17
No

int DEARGB( int AlphaValue, int RedValue, int GreenValue, int BlueValue ){
int RGBColor = DEArgb( AlphaValue, RedValue, GreenValue, BlueValue );
return RGBColor;
}

This is redundant crap.

You should never create do-nothing wrapper functions like this.
If you DO need to have a DEARGB that is just an alias for DEARgb() then you
do NOT create a function like this.
Instead use a #define for the alias.

Suggestion:
Delete this silly function completely and replace it with (in one of your header files)

define DEARGB DEArgb

Go through the rest of the code and get rid of this crap there too and replace it with #define

Discussion

  • Cordier Frédéric ( AmiDARK )

    Hello.
    Concerning the redundant functions, they are here only for Compatibility with DarkBASIC Professional & DarkGDK as these two Game Development Kit each contain both functions.
    As some user on the Amiga Forums and you proposed, this will be fix soonly.

    Thank you for your report.
    Regards,

     
  • Cordier Frédéric ( AmiDARK )

    • status: open --> closed
    • assigned_to: Cordier Frédéric ( AmiDARK )
     
  • Cordier Frédéric ( AmiDARK )

    functions removed and added using #define in the function includes.
    Added also in the user SDK files Basic2D

     

Log in to post a comment.

MongoDB Logo MongoDB