Menu

Patches for amfphp1.9

Developers
2009-01-14
2013-01-04
  • Michael Weck

    Michael Weck - 2009-01-14

    Hi All,

    We use this tool extensively, great job and thanks to all who built it. I have a couple patches that should be fixed in the trunk. Both of these have caused issues only in some instances of the remoting call not being returned to the client or returning BadVersion.

    1.
    In core/amf/app/Gateway.php line:230
    > if(!$outputCompression)
    replace with
    > if(!$outputCompression && isset(($_SERVER['HTTP_ACCEPT_ENCODING']))

    2.
    In core/shared/utils/Headers.php replace class code with the following:
    class Headers
    {  
        static function setHeader($key=NULL, $val=NULL)
        {
            static $headers = array();
            if($val !== NULL)
            {
                $headers[$key] = $val;
            }
            if(isset($headers[$key]))
            {
                return $headers[$key];
            }
            return null;
        }
       
        static function getHeader($key)
        {
            return self::setHeader($key);
        }
    }

    Let me know if you want me to commit this, I will need SVN commit access.

    Best Regards,

    Mike Weck

     
    • kostas kostas

      kostas kostas - 2009-02-19

      Hi mweck

      Before updating amfphp with your notifications i would like to ask you smth.
      Which are the benefits of these notifications - meaning which bugs do these notifications fix.
      And secondly Have you inform the owners-creators of amfphp about your notifications in order to try and check them?

      Cheers

       

Log in to post a comment.

MongoDB Logo MongoDB