[alsa-cvslog] alsa-kernel: hda-intel - Add power_save_controller module option

[Takashi I. <ti...@su...>]

changeset:   5270:e493fabe2797
tag:         tip
user:        tiwai
date:        Mon Aug 13 16:10:30 2007 +0200
files:       Documentation/ALSA-Configuration.txt pci/hda/hda_intel.c
description:
hda-intel - Add power_save_controller module option

Add power_save_controller module option instead of define flag.
Also, added descriptions of new module options in ALSA-Configuration.txt.


diff -r 919eb497be46 -r e493fabe2797 Documentation/ALSA-Configuration.txt
--- a/Documentation/ALSA-Configuration.txt	Mon Aug 13 15:50:29 2007 +0200
+++ b/Documentation/ALSA-Configuration.txt	Mon Aug 13 16:10:30 2007 +0200
@@ -768,6 +768,10 @@ Prior to version 0.9.0rc4 options had a 
     single_cmd  - Use single immediate commands to communicate with
 		codecs (for debugging only)
     enable_msi	- Enable Message Signaled Interrupt (MSI) (default = off)
+    power_save	- Automatic power-saving timtout (in second, 0 =
+		disable, default = 10)
+    power_save_controller - Reset HD-audio controller in power-saving mode
+		(default = on)
 
     This module supports one card and autoprobe.
 
@@ -993,6 +997,12 @@ Prior to version 0.9.0rc4 options had a 
     subsystem ID (output of "lspci -nv") to ALSA BTS or alsa-devel
     ML (see the section "Links and Addresses").
 
+    When CONFIG_SND_HDA_POWER_SAVE is set, two options, power_save and
+    power_save_controller become available.  power_save specifies the
+    time to turn off the power automatically at idle status.  When
+    power_save_controller is true, the controller is also turned off.
+    This might result in more obvious click noise at turning on/off.
+
     Note 2: If you get click noises on output, try the module option
 	    position_fix=1 or 2.  position_fix=1 will use the SD_LPIB
 	    register value without FIFO size correction as the current
diff -r 919eb497be46 -r e493fabe2797 pci/hda/hda_intel.c
--- a/pci/hda/hda_intel.c	Mon Aug 13 15:50:29 2007 +0200
+++ b/pci/hda/hda_intel.c	Mon Aug 13 16:10:30 2007 +0200
@@ -75,7 +75,17 @@ module_param(enable_msi, int, 0);
 module_param(enable_msi, int, 0);
 MODULE_PARM_DESC(enable_msi, "Enable Message Signaled Interrupt (MSI)");
 
+#ifdef CONFIG_SND_HDA_POWER_SAVE
 /* power_save option is defined in hda_codec.c */
+
+/* reset the HD-audio controller in power save mode.
+ * this may give more power-saving, but will take longer time to
+ * wake up.
+ */
+static int power_save_controller = 1;
+module_param(power_save_controller, bool, 0644);
+MODULE_PARM_DESC(power_save_controller, "Reset controller in power save mode.");
+#endif
 
 /* just for backward compatibility */
 static int enable;
@@ -101,17 +111,6 @@ MODULE_DESCRIPTION("Intel HDA driver");
 MODULE_DESCRIPTION("Intel HDA driver");
 
 #define SFX	"hda-intel: "
-
-/*
- * build flags
- */
-
-/*
- * reset the HD-audio controller in power save mode.
- * this may give more power-saving, but will take longer time to
- * wake up.
- */
-#define HDA_POWER_SAVE_RESET_CONTROLLER
 
 
 /*
@@ -1533,10 +1532,8 @@ static void azx_power_notify(struct hda_
 	}
 	if (power_on)
 		azx_init_chip(chip);
-#ifdef HDA_POWER_SAVE_RESET_CONTROLLER
-	else if (chip->running)
+	else if (chip->running && power_save_controller)
 		azx_stop_chip(chip);
-#endif
 }
 #endif /* CONFIG_SND_HDA_POWER_SAVE */