[alsa-cvslog] alsa-kernel: NULL pointer dereference in sound/synth/emux/soundfont.c

[Takashi I. <ti...@su...>]

changeset:   4273:96e63842ba5d73628efab9a051e42a28c38301e8
tag:         tip
user:        tiwai
date:        Wed May 31 11:55:17 2006 +0200
files:       synth/emux/soundfont.c
description:
NULL pointer dereference in sound/synth/emux/soundfont.c

this is about coverity id #100.
It seems the if statement is negated, since the else branch calls
remove_info() with sflist->currsf as a parameter where it gets
dereferenced.

Signed-off-by: Eric Sesterhenn <sna...@gm...>


diff -r 5ccdf2ec174e0083c73759673362dc3d6e094077 -r 96e63842ba5d73628efab9a051e42a28c38301e8 synth/emux/soundfont.c
--- a/synth/emux/soundfont.c	Mon May 29 19:05:28 2006 +0200
+++ b/synth/emux/soundfont.c	Wed May 31 11:55:17 2006 +0200
@@ -195,7 +195,7 @@ snd_soundfont_load(struct snd_sf_list *s
 		break;
 	case SNDRV_SFNT_REMOVE_INFO:
 		/* patch must be opened */
-		if (sflist->currsf) {
+		if (!sflist->currsf) {
 			snd_printk("soundfont: remove_info: patch not opened\n");
 			rc = -EINVAL;
 		} else {