From: J.P. M. <jp...@it...> - 2003-04-29 17:07:11
|
On Mon, 28 Apr 2003 21:17:05 +0200 Grzegorz Adam Hankiewicz <gr...@ti...> wrote: > On 2003-04-28, aj <aj...@oi...> wrote: > > >I have seen a problem in set_gfx_mode() that causes such a > > >crash when calling set_gfx_mode(GFX_TEXT) from graphics mode, > > >and I have a patch that seems to cure it, if you're interested. > > > > i am interested in seeing it become part of allegro if its going > > to fix the problem. > > The crash still has to be verified with a test case: That test case doesn't cause a crash for me. Implementations of malloc and free vary in their details, so a double-free may be safe, may be dangerous, or may be safe _sometimes_. Personally, I suspect that the problem only manifests itself under exceptional memory loads, or it may be that something else is acting as a catalyst. In any case, Allegro does seem to be doing a double-free and this needs fixing. My editor, which does crash, allocates approximately 41MB when running, but this includes lots of very small allocations (on the order of a million). I'm open to the suggestion that it's my code that's causing or helping the crash somehow, but I think this is unlikely since I've checked it with Fortify and nothing comes up. It would be very interesting to compile Allegro with Fortify, but I have not tried this (though I believe someone else did?) > > http://sourceforge.net/mailarchive/message.php?msg_id=4431240 > -- JP Morris - aka DOUG the Eagle (Dragon) -=UDIC=- jp...@it... Fun things to do with the Ultima games http://www.it-he.org Reign of the Just - An Ultima clone http://rotj.it-he.org d+++ e+ N+ T++ Om U1234!56!7'!S'!8!9!KA u++ uC+++ uF+++ uG---- uLB---- uA--- nC+ nR---- nH+++ nP++ nI nPT nS nT wM- wC- y a(YEAR - 1976) |