Menu

#451 Undefined PGCR variables and NOTICE level messages

Git
closed-works-for-me
nobody
None
5
2017-02-20
2015-04-15
No

Adminer doesn't seem to check most POST/GET/REQUEST/COOKIE variables, leading to many NOTICE-level messages when using it on a server configured to show E_NOTICE.

We're integrating adminer (single-file) in our GPLv3 LMS Chamilo, and we are aiming at having everything support E_NOTICE level. As such, I wanted to know if there would be interest in a series of PRs focused on that, or if it's something you (developers) consider a loss of time.

Discussion

  • Jakub Vrána

    Jakub Vrána - 2017-02-20

    Adminer mutes notices by error_reporting. I'm not interested in changing the code to support E_NOTICE error level as it blows the code significantly, makes it less readable and does the checks at the wrong time (only when the code is executed). There are better ways to check if variables are initialized without running the code such as https://code.google.com/archive/p/php-initialized/.

    How were you able to override the error_reporting call that is in the Adminer sources?

     
  • Jakub Vrána

    Jakub Vrána - 2017-02-20
    • status: open --> closed-works-for-me
     

Log in to post a comment.

MongoDB Logo MongoDB