From: Dave H. <hav...@us...> - 2004-09-09 18:35:08
|
On Thu, 2004-09-09 at 11:28, Tolentino, Matthew E wrote: > >What does this end up naming the module? If it ends up being memory.o, > >you might want to think about making it something a bit more > >descriptive. Does it even need to be allowed to be a module, > >or is that > >standard ACPI practice? > > Currently, it names it memory.ko. Len has also suggested that it be > something more like memory_hotplug.ko or memory_hp.ko or something > like that, because the ACPI spec does include verbage about the > system memory map... As this driver does handle "memory" > devices, it kinda makes sense, but we're not wed to any particular > name... ;-) How about including acpi in the name? acpi_memory.o? acpi_memhotplug.o? > >Other than the add/remove_memory() calls does this have any real > >interaction with any non-ACPI code that I overlooked? > > Nope, the only real interaction with the VM is isolated to those > calls. This driver is really only for handling the interaction > with real hardware via ACPI, so it shouldn't need to muck around > with other code... Cool. Looks pretty good. -- Dave |