[ACPI] Fixing broken DSDT - code suggestions for comment please!

[Cam <ca...@me...>]

Hi ACPI list,

I have been trying to get ACPI running on my laptop but have found there 
are problems with the DSDT. I have followed some instructions on getting 
iasl and recompiling the DSDT but find some errors that go beyond the 
scope of the list at:

http://www.cpqlinux.com/acpi-howto.html#fix_broken_dsdt

The errors are:


dsdt.dsl  2149:                     Store (Local0, Local0)
Error    1013 -                                 ^ Method local variable 
is not initialized (Local0)

This occurs several times in the code, a typical case is:

                 Method (_PS0, 0, NotSerialized)
                 {
                     Store (And (0xF0, TIA4), TIA4)
                     Store (0x01, _PSC)
                     Store (Local0, Local0)
                 }

I'm guessing that is effectively a NOP so I can comment it out.

Later there are two other errors not mentioned in the FAQ:

dsdt.dsl  2390:                     Return (WQS (0x0E, Arg0))
Error    1029 -                               ^ Called method returns no 
value
 

dsdt.dsl  2395:                     Return (WQSB (0x0E, Arg0))
Error    1029 - Called method returns no value ^
 


The offending code is:

                 Method (WENR, 1, NotSerialized)
                 {
                     Return (WQS (0x0E, Arg0))
                 }

                 Method (WETR, 1, NotSerialized)
                 {
                     Return (WQSB (0x0E, Arg0))
                 }

All the calls to those methods seem to discard any return value, eg:

         If (\_SB.OKEC)
         {
             \_SB.PCI0.QSB.WENR (0x01F0)
         }

I couldn't find a reference to WETR



So I thought to not return anything:

                 Method (WENR, 1, NotSerialized)
                 {
/*                    Return (WQS (0x0E, Arg0))*/
                     WQS (0x0E, Arg0)
                 }

                 Method (WETR, 1, NotSerialized)
                 {
/*                    Return (WQSB (0x0E, Arg0))*/
                     WQSB (0x0E, Arg0)
                 }

I am more than a bit wary about trying this for real so would appreciate 
  any comments on the dsdt code above. If the fixes are good then maybe 
they could be incorporated into the FAQ?

Any comments gratefully received,

-Cam