#20 problem if the tracktitle contains white spaces

[Fred Kastl]

if the Tracktitle contains white spaces bash terminates
with the following error message
bash: syntax error near unexpected token `('

-vobsubout /mount/filme/matrix_reloaded_disc_1 ( deutsch )

this is becaus of the missing quots,

suggestion:
acidrip.pm:
Line 272:
$menc{'subout'} = $::settings->{'vobsubout'} ?
"-vobsubout $menc{'basename'}" : "";
To:
$menc{'subout'} = $::settings->{'vobsubout'} ?
"-vobsubout \"$menc{'basename'}\"" : "";

2. if the field options in the Section Audio is empty
acidrip creats the following output:
-lavcopts vcodec=mpeg4:vhq:vqmin=2:vbitrate=1625

but mencoder dosn't support -lavcopts without an option

suggestion:
acidrip.pm:
Line 238:
From:
$menc{'audio'} .= " -lameopts
$::settings->{'audio_mp3lame_options'}" if
$::settings->{'audio_codec'} eq 'mp3lame' ;

To:
$menc{'audio'} .= " -lameopts
$::settings->{'audio_mp3lame_options'}" if (
$::settings->{'audio_codec'} eq 'mp3lame' && n
ot $::settings->{'audio_mp3lame_options'} eq "" ) ;

Regards

Fred

[Chris Phillips]

Logged In: YES
user_id=415379

Hi,

thanks for that, i'll try to get that patched asap.

Chris

[Laurent Martelli]

Logged In: YES
user_id=136855

There's also a problem is the target directory contains spaces.

I've fixed that in on_filesize_changed (signals.pm, line
167) by quoting the directory:

open( DF, "df '$directory' |" ) if -w $directory;

[Denis Malinovsky]

Logged In: YES
user_id=951610
Originator: NO

The same problem exists if source folder with DVD files contains spaces. AcidRip complains it can't find any valid files. I guess simple wrapping in quotes won't work since folder name may contain quotes too.

[Lionel Sausin]

Logged In: YES
user_id=72943
Originator: NO

v0.14 still fails to allow spaces in the file name when caching the title.
The cache file is created correctly by mplayer but the mencoder part lacks quoting:

343c343
< "$::settings->{'mencoder'} $menc{'cache'} $menc{'audio'} $menc{'audio_track'} $menc{'video'} $menc{'vf_filters'} $menc{'more_options'} $menc{'af'} $menc{'audio_track'} $menc{'mpegfile'} -o \"$menc{'output'}\""
---
> "$::settings->{'mencoder'} \"$menc{'cache'}\" $menc{'audio'} $menc{'audio_track'} $menc{'video'} $menc{'vf_filters'} $menc{'more_options'} $menc{'af'} $menc{'audio_track'} $menc{'mpegfile'} -o \"$menc{'output'}\""