Re: [Accel-ppp-users] [PATCH 0/7] iputils: stricter route deletion and cleanup

[Dmitry K. <xe...@ma...>]

>This series brings the ability to use the same parameters in
>iproute_del() as in iproute_add(). The objective is to ensure that
>we only delete routes that have the same properties as the ones we
>originally inserted.
>
>The rest of the series makes some cleanup in the rest of iputils.c,
>simplifying a bit netlink header generation.
>
>Patch 1 adds the 'src' and 'gw' parameters to iproute_del().
>
>Patch 2 uses the new 'gw' parameter in radius.c.
>
>Patch 7 uses 'src' in ipoe.c. I put this patch at the end of the series
>and mark it RFC as I don't have any working IPoE environment to test
>it. The route insertion and deletion process looks quite clear, and
>setting 'src' there seems to fit properly.
>
>Then patches 3 to 6 simplify a little bit the way netlink messages are
>generated, without modifying their semantic.
>
>Guillaume Nault (7):
>  iputils: add 'src' and 'gw' parameters to iproute_del()
>  radius: specify gateway in iproute_del()
>  iputils: set scope depending on gateway in iproute_{add,del}()
>  iputils: always set scope to RT_SCOPE_UNIVERSE in ip6route_{add,del}()
>  iputils: remove NLM_F_CREATE flag from ip6{route,addr}_del()
>  iputils: remove unnecessary NLM_F_ACK
>  ipoe: stricter route deletion
>
> accel-pppd/ctrl/ipoe/ipoe.c     | 10 +++++-----
> accel-pppd/libnetlink/iputils.c | 29 ++++++++++++++++-------------
> accel-pppd/libnetlink/iputils.h |  2 +-
> accel-pppd/radius/radius.c      |  2 +-
> 4 files changed, 23 insertions(+), 20 deletions(-)
>
>-- 
>2.20.1
>

Applied, thanks

-- 
Dmitry Kozlov