accada-epcis-developer Mailing List for Fosstrak EPCIS

SourceForge Headquarters 1320 Columbia Street Suite 310 San Diego, CA 92101 +1 (858) 422-6466

Bugs item #3435025, was opened at 2011-11-08 08:24
Message generated for change (Comment added) made by keitamiyazaki
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=856005&aid=3435025&group_id=170911

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: epcis-repository
Group: v0.5
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Nobody/Anonymous (nobody)
Assigned to: Nobody/Anonymous (nobody)
Summary: GE_recordTime is not updated correctly in subscriptions

Initial Comment:
I noticed that after first output message sent through a subscription it stops functioning correctly with following error:


<?xml version="1.0" encoding="UTF-8" standalone="yes"?>
<ns3:EPCISQueryDocument schemaVersion="1.0" creationDate="2011-11-08T17:03:30.703+01:00" xmlns:ns2="http://www.unece.org/cefact/namespaces/StandardBusinessDocumentHeader" xmlns:ns4="urn:epcglobal:epcis:xsd:1" xmlns:ns3="urn:epcglobal:epcis-query:xsd:1" xmlns:ns5="urn:epcglobal:epcis-masterdata:xsd:1">
    <EPCISBody>
        <ns3:ImplementationException>
            <reason>An unexpected error occurred while executing a subscribed query</reason>
            <queryName>SimpleEventQuery</queryName>
            <subscriptionID>127</subscriptionID>
        </ns3:ImplementationException>
    </EPCISBody>
</ns3:EPCISQueryDocument>


Looking into logs detected that after execution GE_recordTime parameter gets updated in wrong format:


DEBUG (2011-11-08 17:03:10,398) [org.fosstrak.epcis.repository.query.QuerySubscription:237] - Executing subscribed query '127' with 1 parameters:
DEBUG (2011-11-08 17:03:10,398) [org.fosstrak.epcis.repository.query.QuerySubscription:240] -  param name:  GE_recordTime
DEBUG (2011-11-08 17:03:10,398) [org.fosstrak.epcis.repository.query.QuerySubscription:245] -  param value: 1320768180197


Looking at QuerySubscription.updateRecordTime I see that the param is set in milliseconds, not as GregorianCalendar:

    private void updateRecordTime(final QueryParams queryParams, final Calendar initialRecordTime) {
        // update or add GE_recordTime restriction
        boolean foundRecordTime = false;
        for (QueryParam p : this.queryParams.getParam()) {
            if (p.getName().equalsIgnoreCase("GE_recordTime")) {
                LOG.debug("Updating query parameter 'GE_recordTime' with value '" + initialRecordTime + "'.");
                p.setValue(initialRecordTime.getTimeInMillis());
                foundRecordTime = true;
                break;
            }
        }
        if (!foundRecordTime) {
            LOG.debug("Adding query parameter 'GE_recordTime' with value '" + initialRecordTime + "'.");
            QueryParam newParam = new QueryParam();
            newParam.setName("GE_recordTime");
            newParam.setValue(initialRecordTime);
            this.queryParams.getParam().add(newParam);
        }

        // update the subscription in the db
        updateSubscription(initialRecordTime);
    }


That messes the whole subscriptions implementations.


----------------------------------------------------------------------

Comment By: Keita Miyazaki (keitamiyazaki)
Date: 2011-12-02 08:56

Message:
I think it is because "parseAsCalendar" method may process data formatted
in only "plusmnYYYY-MM-DDThh:mm:ss[.S]TZD".

Please find the attached patch code.
/$HOME/Documents/workspace/epcis/epcis-repository% patch -p0 -E < patch.txt

Index:
src/main/java/org/fosstrak/epcis/repository/query/QueryOperationsModule.java
===================================================================
---
src/main/java/org/fosstrak/epcis/repository/query/QueryOperationsModule.java	(リビジョン
1875)
+++
src/main/java/org/fosstrak/epcis/repository/query/QueryOperationsModule.java	(作業コピー)
@@ -23,6 +23,7 @@
 import java.net.MalformedURLException;
 import java.net.URL;
 import java.sql.SQLException;
+import java.sql.Timestamp;
 import java.text.ParseException;
 import java.util.ArrayList;
 import java.util.Calendar;
@@ -267,7 +268,7 @@
                     }
                 } else if (paramName.equals("GE_eventTime") ||
paramName.equals("LT_eventTime")
                         || paramName.equals("GE_recordTime") ||
paramName.equals("LT_recordTime")) {
-                	Calendar cal = parseAsCalendar(paramValue, paramName);
+                    Calendar cal = parseAsCalendar(paramValue, paramName);
                     Operation op =
Operation.valueOf(paramName.substring(0, 2));
                     String eventField = paramName.substring(3,
paramName.length()) + "Ms";
                     aggrEventQuery.addEventQueryParam(eventField, op,
cal.getTimeInMillis());
@@ -686,6 +687,10 @@
             // CXF returns an XMLGregorianCalendar instance if the
             // XML type is specified
             cal = ((XMLGregorianCalendar)
queryParamValue).toGregorianCalendar();
+        } else if (queryParamValue instanceof Long){
+            // try to parse the Long value as timestamp
+            Timestamp tm = new
Timestamp(((Long)queryParamValue).longValue());
+            cal = TimeParser.convert(tm);
         } else {
             // try to parse the value manually
             String date = null;


----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=856005&aid=3435025&group_id=170911




2007	Jan	Feb	Mar	Apr	May (1)	Jun (4)	Jul (2)	Aug (7)	Sep (9)	Oct (2)	Nov (4)	Dec (17)
2008	Jan (14)	Feb (3)	Mar (8)	Apr (9)	May (4)	Jun (4)	Jul (5)	Aug (6)	Sep (12)	Oct	Nov (8)	Dec (33)
2009	Jan (7)	Feb (17)	Mar (17)	Apr (1)	May (1)	Jun (4)	Jul (8)	Aug (8)	Sep (1)	Oct	Nov	Dec
2010	Jan (1)	Feb (3)	Mar (1)	Apr (2)	May (1)	Jun	Jul (16)	Aug (5)	Sep	Oct	Nov	Dec (1)
2011	Jan (2)	Feb	Mar	Apr	May	Jun (2)	Jul	Aug	Sep	Oct (1)	Nov (3)	Dec (1)

accada-epcis-developer Mailing List for Fosstrak EPCIS

accada-epcis-developer — Accada EPCIS Developer Mailing List