Re: [Abook-devel] [Fwd: [patch] import of ldif files]

[Raphaël <rap...@gm...>]

I pushed 3 new commits about ldif.
By date desc:
* don't force output to latin1 anymore
* ldif export all available emails
* ldif import reworked (2f827e0e)

2f827e0e is a big commit which intends to fix all the issues related to
fields names mappings, while paving the way for a more adaptive ldif importer.

The "objectclass" hunk (removed in 83fc8566) is now written:
> if( !li[LDIF_OBJECTCLASS] ) goto bail_out;

Custom fields are not yet imported (nor exported) but I hope the new
code-base may support that (more) easily.


enjoy


On Thu, Dec 13, 2012 at 08:27:33PM +0100, Christian Brabandt wrote:
> Hi Raphaël!
> 
> On Do, 13 Dez 2012, Raphaël wrote:
> 
> > You may want to also test the 4 following commits, respectively:
> > * don't reject LDIF records not having a "xmozillanickname"
> <snip>
> --- a/filter.c
> +++ b/filter.c
> @@ -609,10 +609,6 @@ ldif_add_item(ldif_item li)
>  
>         item = item_create();
>  
> -       if(!li[LDIF_ITEM_FIELDS -1])
> -               goto bail_out;
> -
> -
> 
> I am not sure this is actually correct. I think, this will always be 
> field objetclass which I think, always needs to be present.
> 
> So this is actualy useful, to discard invalid ldif files.
> 
> regards,
> Christian