Re: [Abook-devel] Patches: groups, color, and mouse support

[Thorsten W. <ed...@th...>]

On Mon, Apr 16, 2012 at 04:05:26PM +0200, Raphaël Droz wrote:
> On Sun, Apr 15, 2012 at 10:33:40AM +0200, Fabio Zanini wrote:
> > recently Thorsten Wißmann and I wrote some code to include basic support
> > for:
> > - mouse (Thorsten)
> > - colors (Thorsten)
> > - mutt groups (mine)
> 
> Wow, seems great !
>
> Opening the dance with a very quick review of the mouse and color
> features (which appear to work flawlessly).

Thanks!

> * In abookrc.5 there's "use_color" instead of "use_colors"
> 
> * In options.c you use UL FALSE rather than simply FALSE (while I don't
>   think we need to explicitly cast 0 or 1 to (unsigned long) here)

You're right, both are fixed now.

> * About colors options naming and after reading naively the new manpage
>   section, I think that something like:
> color_list_even_* / color_list_odd_*
>   may be more explicit semantics than:
> color_list_* / color_list_alternate_*

I renamed them to color_list_{even,odd}_{fg,bg}, where the first entry
in the list is *even* (starting with index 0), because it feels odd to
colorize the first item with color_list_odd_{fg,bg}.

> * mouse support is nice but making it optional would be even better,
> [..]

Of course! Now it can be activated with the use_mouse option. It's
disabled by default like in many applications (vim, weechat, ...).

I also fixed the annoying lag between a click and the reaction by abook.
Now the mouse should just work as expected™. Can someone test it and
give feedback? (Then we could enable it by default)

All changes are committed to my mouse_color branch you can get via

    git clone git://git.informatik.uni-erlangen.de/re06huxa/abook

or browse on

    http://git.informatik.uni-erlangen.de/?p=re06huxa/abook

Thorsten