Re: [Abook-devel] abook 0.6.0pre2

[Cedric D. <ced...@fr...>]

Hi Mich=E8le,

first of all, thanks a lot for the detailed bug reports. :)

Mich=E8le Garoche wrote:
> A - Comma is transformed in underscore in address field and in =20
> database when using abookrc sample file

Yes, this was originally "by design" that lists are comma separated. It
made sense for email lists, but now that lists are "all-purpose", this
is a bit unfortunate. We have to find something better.

> B - The bscal function changes the anniversary field only in the =20
> view, not in the database, when sample abookrc file is used.

Fixed in CVS.

> C - The anniversay field, which is noted as standard field in man =20
> page is not loaded at launch time when not using abookrc sample file

Well, at the time I did not add it since
 1/ it was not a real "legacy" field
 2/ date type was not supported yet

Now that we have 2/, I think it makes sense to have it.
It is now in CVS.

> D - The bscal function changes the anniversary field only in the =20
> view, not in the database.
>=20
> When the patch in C is applied, a similar change to the one noted in =20
> B occurs in the Anniversary field, but this time the field becomes =20
> empty.

Should be ok now.

> F - There is a discrepancy between the abookrc.5 man page and the =20
> sample.abookrc
[...]
> Note 13 characters in phone: explaination, but 12 in Default.

Ok, now 12 in both.

> E - A minor esthetic problem in help
>=20
> I've just noticed that there is one tabulation too many in the  =20
> message of line 20 in help.h, it makes the explaination shift from =20
> the other ones.

I can't reproduce this one. All strings seem perfectly aligned.

> So, I've corrected the fr.po file, but it affects all the po file and =20
> obviously the help.c file.

The abook-fr-po-0.6.0pre2-patch.tar.bz2 you attached in your mail does
not contain any po file, just the patch for C. ;)

> Here's the new fr.po file (some corrections and new translations).

Again, many thanks for taking the time to write extensive feedback.

--=20
C=E9dric