Good catch Tony ! I've committed the changes as you suggested. Also I've
fixed the "always return zero" issue, by calculating the workflow duration
and converting it to hours. Can you help me with an review ?
The reason is because this time is based in the Duration Unit from workflow head and UOM of Resource, So I think we need more work here for get the Right Capacity.
Environment:
Resource UOM in Hours
Workflow Duration Units based in Hours
The focus current would work right
Resource in Days
Workflow Duration Units based in Hours
The focus current do not is right
Resource in hours
Workflow Duration Units based in second
The focus current do not is right
etc ....
Teo Thank for wonderful work, this way I am very happy to help
.
The Community Power :-)
Kind regards
Victor Perez
www.e-evolution.com
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
> Resource in hours
> Workflow Duration Units based in second
>
> The focus current do not is right
I think i don't understand correctly what are you saying.
1. How should we solve this case ?
2. From where should we take the UOM. From S_ResourceType.C_UOM_ID ? From M_Product.C_UOM_ID ?
3. In this case, which is the use of DurationUnit ?
Best regards,
Teo Sarca
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Hi Teo!
I saw your change in this revision
Good catch Tony ! I've committed the changes as you suggested. Also I've
fixed the "always return zero" issue, by calculating the workflow duration
and converting it to hours. Can you help me with an review ?
Revision: 6157
http://adempiere.svn.sourceforge.net/adempiere/?rev=6157&view=rev
Author: teo_sarca
Date: 2008-08-19 15:59:30 +0000 (Tue, 19 Aug 2008)
Log Message:
-----------
BF [ 2051941 ] MPPMPRP.getHoursAvailable hardcoded 6750000 ?
BF [ 2053279 ] MPPMPRP.getDays always returns zero.
* added some more javadoc comments
* fixed some warnings
Modified Paths:
--------------
branches/stable/base/src/org/eevolution/model/MPPMRP.java
I only think here we can will have some issue
674 ( wf.getQueuingTime()
675 + wf.getSetupTime()
676 + (wf.getDuration() * QtyOrdered.doubleValue())
677 + wf.getWaitingTime()
678 + wf.getMovingTime()
679 )
680 * ( wf.getDurationBaseSec() / 60 / 60 ) // convert to hours
681 );
The reason is because this time is based in the Duration Unit from workflow head and UOM of Resource, So I think we need more work here for get the Right Capacity.
Environment:
Resource UOM in Hours
Workflow Duration Units based in Hours
The focus current would work right
Resource in Days
Workflow Duration Units based in Hours
The focus current do not is right
Resource in hours
Workflow Duration Units based in second
The focus current do not is right
etc ....
Teo Thank for wonderful work, this way I am very happy to help
.
The Community Power :-)
Kind regards
Victor Perez
www.e-evolution.com
Hi Victor,
> Resource in hours
> Workflow Duration Units based in second
>
> The focus current do not is right
I think i don't understand correctly what are you saying.
1. How should we solve this case ?
2. From where should we take the UOM. From S_ResourceType.C_UOM_ID ? From M_Product.C_UOM_ID ?
3. In this case, which is the use of DurationUnit ?
Best regards,
Teo Sarca