queues in 2.8

Didn't work for me, but thanks for trying.

I found this in another thread about the same problem in 2.8b1.  I didn't write this, someone else did, but I forgot to look at who it was, but because the search feature is such a pain to use and I'm lazy I'll just hope that they'll forgive me for not giving credit:
***************************

The bug is caused by the empty Playback command. which is causing the script to fail. Here is the line from voip-info.org

Returns -1 if the channel was hung up, or if the file does not exist. Returns 0 otherwise. 

The playback command is empty because there is no "entry announcement" set. 

Here is a fix:

Edit the file:
/var/www/html/admin/modules/queues/functions.inc.php

Find the line:
$addarray = array('ext-queues',$account,'4','Playback',$joinannounce,'','0');

which is about 15 lines down from function queues_add

And change this line to read:
if (!empty($joinannounce) && $joinannounce != 'None')
{
$addarray = array('ext-queues',$account,'4','Playback',$joinannounce,'','0');
legacy_extensions_add($addarray);
}

This will stop the insertion of the empty playback line if there is no announcement set.

AndrewG, can you please submit this to the good people over at AMP.

bummer, ztirffritz.

Here is my most recent progress.  I added (at line 98 of modules/queues/functions.inc.php):

    if (!empty($joinannounce) && $joinannounce != 'None')
        $joinannounce="$joinannounce";
    else
        $joinannounce="";

now when i define a queue in freepbx without a join announcement it does not write the playback line at all. this seems to work well.  each queue i add seems to work without issue.  i am running the latest (2.8) in a virtual machine.

when i do want to play an announcement the line is written and that works as well. 

i am putting a time limit of 1'30" on my queues and testing with a single local extension for the agent.

hope you can get yours working.

duh.  too slow.  wish i had seen that post earlier.  that is what search is for, i suppose.

It still doesn't work for me.

ok now i am really confused, ztirffritz seemed to have posted a fix but then the lastest posting says "still doesnt work"

So whats not working and what is working, the fix by eliottspencer or the fix by ztirffritz?

Can someone post in one message the fix which will resolve all issues with echo, it would be most appreciated

Thanks

I've tried them both and neither work for me.  I'm not sure what I'm doing wrong.

Both of these work fine for me.

In extensions_additional.conf, I changed the playback lines to read:
exten => 110,n,Playback(custom/None)

Saved, then re-read config changes and it worked.
Once I resubmitted the queue, it broke it again.

Then in /var/www/html/admin/modules/queues/functions.inc.php
I found the line with $addarray = array('ext-queues',$account,'4','Playback',$joinannounce,'','0');

And I added right before it:
if (!empty($joinannounce) && $joinannounce != 'None')
{

And After
legacy_extensions_add($addarray);

I added  }

So the output from before $addarray =    array('ext-queues',$account,'4','Playback',$joinannounce,'','0');
is changed to:
        if (!empty($joinannounce) && $joinannounce != 'None')
        {
        $addarray = array('ext-queues',$account,'4','Playback',$joinannounce,'','0');
        legacy_extensions_add($addarray);
        }

Saved the file, resaved the queue and it omitted the Playback line and it rings the phone.

OK I tried doing one, then the other, but it appears that it undid the first change that I made.  I did it again and made sure that the changes stuck and it seems to be working now, but there's no music on hold.  I'll keep working on it.  Thanks.

OK, I am unable to even create a queue now.  The ones I have work, but if I try to create a new one I get this on the FreePBX screen:

DB Error: already existsINSERT INTO extensions (context, extension, priority, application, args, descr, flags) VALUES ('ext-queues', '125', '1', 'Answer', '', '' , '0')

This is really weird.  I deleted all of my queues.  Then tried to recreate them.  Queue 123...no problems.  Queue 124...no problems.  Quere 125...see error message above.  Is 125 reserved for something in Asterisk?

I tried 126 and it worked just fine.

ok, here goes again, so now with all these responses i think we are just creating more confusion again.

To recap: there were two solutions pointed out, d127001 did both.  then followed up ztirffritz that said it didnt work then it worked.

So maybe someone can clear this up
1.  Is the recap of d127001 actually a fix?
2.  Does both things eliottspencer posted and ztirffritz necessary to make things work or just one of them?
3. has anyone tried this on 2.8 Beta1?

OK, I think that the process is this:
1)Delete all your existing queues.
2) modify /var/www/html/admin/modules/queues/functions.inc.php   as instructed in my post
3) save the changes
4) create the queues
5) good luck

Didnt work, i did exactly what you listed ztirffritz and sure enough i got a hung up.  I started completely clean by deleting all the existing Queues, but no luck.

The only thing is i am using Beta1 2.8

i am also getting the following when trying to add a new queue, strangely this error didnt come up after i did your instructions and added my first new queue, but i tried adding a 2nd queue and i get the following:
DB Error: already existsINSERT INTO extensions (context, extension, priority, application, args, descr, flags) VALUES ('', '', '', '', '', '' , '')

ignore the last post, that was my error, however hangup still exists as i posted before, the DB issue was me having legacy_extensions_add($addarray); listed twice, but the rest is per your instructions

ok now i am trying to put things back to the way they were before but i now keep gettting the following even when i have changed back the code

DB Error: already existsINSERT INTO extensions (context, extension, priority, application, args, descr, flags) VALUES ('ext-queues', '3200', '4', 'Playback', 'None', '' , '0')

ok i have tried clearing out the database as well for queues and extensions to ensure no issues.  I still find the immediate hangup occurs, however i narrowed down the error above, this will occur anytime you choose an option for the "Join Announcement" field.  i have tried new queues with completely new numbers and still every time i choose something from this drop down i get:
DB Error: already existsINSERT INTO extensions (context, extension, priority, application, args, descr, flags) VALUES ('ext-queues', '400', '4', 'Playback', '2', '' , '0')

However when i leave empty the Queues get created but still even when created they arent working, the call simply drops.

ok i think i got it working now, i decided to forget all this editing and just scrap the whole thing because it just wasnt working (at least not for me, maybe it was bec i was on Beta1).

Anyway - I went to FreePBX and went to the "Browse Source" i figured if anyone updated and fixed it then it would exist here.

So i went ahead and basically deleted all the files under /var/www/html/admin/modules/queues except for module.ini

Then i download the queue tar from Freepbx (link below)
http://freepbx.org/browser/amportal/modules/release/queues-1.0.tgz

Then i extracted and copied the files into /var/www/html/admin/modules/queues

Once i did this i reloaded the configs and sure enough everything worked.

I tried creating queues that had and didnt have Join Announcement option selected.

Cant say for sure whether there arent still bugs but so far so good, anyway just wanted to share

How did you unpack the file?  I'm trying:
tar -xvf queues-1.0.tgz
but it is not working.

Hey guys,
         Will this fix work in aah 2.5 with fpbx 2.01?

TIA,

R-

i didnt unpack it in linux, i used Webmin and via File Manager i uploaded the file and chose to unpack during the upload.

As per the other post from sunliner, i have no idea, back up the files and apply these new queue module files, if it works then there you go, but i am on 2.8 only so cant really say if 2.5 with fpbx 2.01 will work