-
4) As it is necessary to access single bytes at several places in the code it's not easily possible to always use UINT32. For the time beeing I'll leave the code as is. If I find a simple solution to eliminate these warnings I'll certainly implement it.
5)
a) Changed in SVN.
b) In SVN I put "10" instead of "10.0" and added a (redundant) int cast. I think rounding is definitely not needed...
2009-10-26 08:08:29 UTC in wxCode - wxWidgets components
-
utelle committed revision 1028 to the wxCode - wxWidgets components SVN repository, changing 2 files.
2009-10-25 16:22:15 UTC in wxCode - wxWidgets components
-
4) Of course one could rewrite the code to use always UINT8 by writing a small loop instead of 4 statements using UINT32. But is this really a serious issue? The code was the same for years now and noone complained so far that it did not work. So what should I do?
5)
a) I'll place the assignment in a comment.
b) Strange since writing 10 without decimal point should make the division an...
2009-10-25 13:38:43 UTC in wxCode - wxWidgets components
-
4) gcc 4.3.2 - the compiler version I use currently in my Linux environment - does not emit those warnings (with option -Wall). I'm not sure what to do about this. Probably using -fno-strict-aliasing (at least for pdfrijndael.cpp) would eliminate the warnings.
5)
a) pdffontparsertruetype: Indeed the variable oldfont is assigned but not used. I didn't eliminate this assignment since I'm not...
2009-10-25 12:39:14 UTC in wxCode - wxWidgets components
-
2) and 3) are now fixed in wxCode SVN.
3) Well, you are right, the #ifdefs could be grouped together, but it really doesn't matter.
4) The variables are defined as UINT8 since they are used as such at several places. The code is based on the Rijndael implementation by Szymon Stefanek. I think the casts to UINT32 are applied to speed up the execution. Visual C++ does not emit warnings...
2009-10-25 07:24:36 UTC in wxCode - wxWidgets components
-
utelle committed revision 1026 to the wxCode - wxWidgets components SVN repository, changing 2 files.
2009-10-25 06:56:28 UTC in wxCode - wxWidgets components
-
2) Maybe precompiled headers are handled differently by Visual C++ than by gcc/mingw. Or there was a change from wxW 2.9.0 to 2.9.1. I'll add the missing #include in SVN soon.
3) Certainly the #defines look a bit strange but DEBUG_NEW is definitely defined only once.
2009-10-24 22:26:37 UTC in wxCode - wxWidgets components
-
1) Extra spaces
It seems that the Visual C++ editor leaves those extra spaces. I'll check whether there is an option to clean up the code in this respect.
2) Inclusion of wx/msw/private.h
It's certainly not a problem to add this include but I'd like to understand why this is necessary. Could you please explain. (When compiling with Visual C++ I don't get errors or warnings.)
3...
2009-10-24 21:11:44 UTC in wxCode - wxWidgets components
-
utelle committed revision 1004 to the wxCode - wxWidgets components SVN repository, changing 3 files.
2009-10-16 20:15:42 UTC in wxCode - wxWidgets components
-
utelle committed revision 1001 to the wxCode - wxWidgets components SVN repository, changing 9 files.
2009-10-16 19:47:05 UTC in wxCode - wxWidgets components
