Magnus Holmgren

Show:

What's happening?

  • Too many compiler warnings due to too little use of const et

    Russel Coker thinks you're too sloppy with const among other things. See http://bugs.debian.org/524133. Here is a patch. Naturally, you have to enable warnings to see them. :-)

    2009-08-02 20:23:16 UTC in Alt-N Technologies DKIM Project

  • strtok() is not thread safe

    Russel Coker pointed out (see http://bugs.debian.org/532740) that libdkim uses strtok(), which is not reentrant, making libdkim unsuitable in multithreaded applications. His patch is attached.

    2009-08-02 19:22:47 UTC in Alt-N Technologies DKIM Project

  • Test suite not depending on Internet connectivity

    It would be nice if you could let policy.t and public_key.t share the "fake DNS" in verifier.t, such that the test suite doesn't depend on the Internet being available. (The build environment on Debian's autobuilders doesn't provide network connectivity, and anyway, Internet connections fail now and then and I don't think that should cause unit tests to fail.)

    2009-08-01 16:37:31 UTC in DKIMproxy

  • File names of static libraries should not include version

    Static libraries on at least Linux do not include the version in their file names unless the version is part of the name (in which case it also appears before the .so in the shared library file name). Including the version makes linking against the library inconvenient because you have to modify the configure parameters to match the exakt version of the library. Even pkg-config doesn't return...

    2008-05-17 20:32:03 UTC in Pre Make Kit

  • Comment: Setting soname

    Any progress on this one? Being able to set the soname is more or less essential for pmk to be usable in distributions like Debian. I can see the potential problem that you might have to store information about every combination of OS and linker. As I described earlier it is also important that pmk can generate the file name of a library without version number as well as with just the...

    2008-05-17 20:14:20 UTC in Pre Make Kit

  • Comment: pmkscan generate bad OBJS lists

    pmkscan still fails to include dkimverify.o and dkimbase.o in LIBDKIMTEST_OBJS in my example. Shall I open a separate bug/wish?.

    2008-05-17 19:57:59 UTC in Pre Make Kit

  • Broken Makefile.pmk when setting LINKER = "CXX" in scanfile

    I guessed incorrectly and set LINKER = "CXX" instead of "C++" in a DEFINE_LIB block in a scanfile. pmkscan didn't complain however, but produced a Makefile.pmk with no c_shared_libs* or cxx_shared_libs* targets. That's fine, but pmk still set @SHARED_LIB_TARGETS@ to "c_shared_libs cxx_shared_libs" and so on for @SHLIB_CLEAN_TARGETS@ etc.

    2008-05-17 19:54:52 UTC in Pre Make Kit

  • Comment: Help/About close button does not work

    Here's the patch I've used in the Debian package (why can't I attach files to existing bugs?): diff -urNad trunk~/pyscrabble/gtkutil.py trunk/pyscrabble/gtkutil.py --- trunk~/pyscrabble/gtkutil.py 2006-12-05 15:49:00.000000000 +0100 +++ trunk/pyscrabble/gtkutil.py 2007-10-03 16:30:51.000000000 +0200 @@ -73,6 +73,7 @@ dialog.set_translator_credits(_('translator-credits')...

    2008-05-01 21:11:54 UTC in PyScrabble

  • Comment: Suggested changes, in particular wrt server configuration

    One more thing: To comply with the FHS, data files should be under /usr/share/games/pyscrabble instead of /usr/share/pyscrabble.

    2007-09-30 17:26:43 UTC in PyScrabble

  • Names of scripts inconsistent and server_console too generic

    I suggest renaming pyscrabble-main.py to just pyscrabble, and server_console.py to pyscrabble-server (that's what I plan to do in the Debian package), at least on Unix-like OSes. There the hashbang line tells the OS to run the python interpreter, so the .py suffix is unnecessary. As a program installed in /usr/bin (or /usr/games, which is the correct place for a game), server_console.py...

    2007-09-30 17:23:09 UTC in PyScrabble

About Me

  • 2002-12-14 (7 years ago)
  • 669310
  • proffe (My Site)
  • Magnus Holmgren

Send me a message