-
I found a flaw in my patch: the MAX_OIDS limit was no longer being enforced, allowing for a potential buffer overflow. I've attached a patch against the git master to fix this.
2009-03-17 22:34:13 UTC in Nagios Plugin Development
-
I just used the tests in t/check_snmp.t plus a few others more specific to our environment. Almost all of my extra tests, like the extend tests, wouldn't necessarily work elsewhere. About the only test you'd find useful
to add is one of multiple OIDs:
$res = NPTest->testCmd( "./check_snmp -H $host_snmp -C $snmp_community -o host.hrStorage.hrMemorySize.0,host.hrSystem.hrSystemProcesses.0 -w...
2009-03-13 23:56:05 UTC in Nagios Plugin Development
-
tonvoon: I see, I thought you were referring to plugins/runcmd.c.
I've attached a patch against the SVN trunk that changes check_snmp to use lib/utils_cmd.c. It's passed all the tests I've thrown at it, including extend OIDs. This wasn't a trivial patch, and my C foo isn't great, so please modify as necessary.
2009-03-13 21:14:21 UTC in Nagios Plugin Development
-
I looked into writing a patch using the runcmd library, but I don't see this function you're referring to.
np_runcmd_open() looks pretty similar to spopen(), with the same double quotes restriction.
The old exec method of running external commands is deprecated, so I'd really like to get extend working.
2009-03-11 20:34:27 UTC in Nagios Plugin Development
