Michael Zeilfelder

fix CGUIScrollBar TrayClick

I get the reasoning - it's pretty closely related to https://sourceforge.net/p/irrlicht/bugs/328/. Just removing animation feature is not the solution. So unless we have really a better solution using addToDeletionQueue etc for such events is an OK enough workaround.

I don't consider it an anti-pattern, just a new one not used yet in other places. Irrlicht doesn't have other animations in UI yet, but events at end of animations are not really such an uncommon thing in libraries. And one place always has to start.

To remove elements safely in OnPostRender you can use addToDeletionQueue (instead of usual remove()). If you really need to add an element in that event then delay it yourself somehow. Not sure why you would put mutexes in the event-handler, that sounds pretty specific. I agree it can be a bit risk, but not exactly one that you can't avoid. And I also don't think sending events from animations is really bad. Events can be send from anywhere. If you have some case where you really can't work around...

More patches from my fork

Thank you, I should have seen those.

More fixes for compiling without GL_VERSION_3_2

Thanks, I indeed forgot to check version in a few places for that one. I hope [r6823] fixes all those