Ahnfelt

What's happening?

Followup: RE: Memory leaks in operator=

I think you're right. Fixing a memory leak by introducing a segfault... whoops!

2009-03-08 09:45:05 UTC in PNGwriter
Memory leaks in operator=

The memory for the existing image is not freed. This fix avoids reallocating memory if the dimensions haven't changed. I haven't checked pngwriter(pngwriter&), but that might be problematic in the same way. Here's a diff: 545a546,547 > int original_width = width_; > int original_height = height_; 552a555,559 > delete filename_; > delete textauthor_;...

2009-03-06 01:05:13 UTC in PNGwriter
Missing div-by-zero check in drawbottom_blend

gdb output: Program received signal SIGFPE, Arithmetic exception. 0x0804c78d in pngwriter::drawbottom_blend (this=0xbf89fbdc, x1=9, y1=39, x2=85, x3=93, y3=39, opacity=0.72510022277715624, red=7242, green=18984, blue=24996) at pngwriter.cc:4536 4536 long cl=((x3-x1)*256)/(y3-y1); (note that y1 == y3)

2009-03-03 21:34:30 UTC in PNGwriter