Miklos Vajna

It isn't too complex: you just perform your function calls on libepubgen::EPUBTextGenerator and you assert the result (or the lack of it) at the end. I've added a test for this now, see commit 1c4edb690e4ad248d214d199797df5318529f910. Hopefully you can write a similar test for your next fix. :-) And yes, fixing epubchecker warnings is great, thanks for that.

Exclude direction CSS property on EPUB 3

Let me merge this as-is, but please do consider adding a test to cover this, in a follow-up merge quest. :-) Thanks!

Thanks, this looks good. Did you consider covering your change with a test in src/test/EPUBTextGeneratorTest.cpp? You could add an assertXPathNoAttribute() and then this should be straightforward to test. Or I can do that for you, this is your first commit after all. :-)

This looks sane to me. Alonso: do you have any further comments? Miklos

The patch looks good to me mostly. A nitpick: please auto auto conservatively: if the type info is already spelled out in the same line, for iterators and for range-based for loops. auto *rubyText = propList["text:ruby-text"]; is a bit hard to read to my simple mind. Otherwise feel free to push the patch.

Reproducer file.

C++11 override makes a C++ member function declaration ignored